( )⚙ D7284 mdiff: mark diffopts as having dynamic attributes

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7284

mdiff: mark diffopts as having dynamic attributes
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:58 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGf2f460cdb4f5: mdiff: mark diffopts as having dynamic attributes
Summary

This class looks like we could move it to being an attrs and life
would be better, but let's do that later.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 6 2019, 5:58 PM
indygreg accepted this revision.Nov 7 2019, 3:18 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:18 AM
durin42 added a commit: rHGf2f460cdb4f5: mdiff: mark diffopts as having dynamic attributes.Nov 7 2019, 3:34 AM
Closed by commit rHGf2f460cdb4f5: mdiff: mark diffopts as having dynamic attributes (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/mdiff.py (3 lines)

Diff 17654

mercurial/mdiff.py

blocks = bdiff.blocks blocks = bdiff.blocks
fixws = bdiff.fixws fixws = bdiff.fixws
patches = mpatch.patches patches = mpatch.patches
patchedsize = mpatch.patchedsize patchedsize = mpatch.patchedsize
textdiff = bdiff.bdiff textdiff = bdiff.bdiff
splitnewlines = bdiff.splitnewlines splitnewlines = bdiff.splitnewlines
# TODO: this looks like it could be an attrs, which might help pytype
class diffopts(object): class diffopts(object):
'''context is the number of context lines '''context is the number of context lines
text treats all files as text text treats all files as text
showfunc enables diff -p output showfunc enables diff -p output
git enables the git extended patch format git enables the git extended patch format
nodates removes dates from diff headers nodates removes dates from diff headers
nobinary ignores binary files nobinary ignores binary files
noprefix disables the 'a/' and 'b/' prefixes (ignored in plain mode) noprefix disables the 'a/' and 'b/' prefixes (ignored in plain mode)
ignorews ignores all whitespace changes in the diff ignorews ignores all whitespace changes in the diff
ignorewsamount ignores changes in the amount of whitespace ignorewsamount ignores changes in the amount of whitespace
ignoreblanklines ignores changes whose lines are all blank ignoreblanklines ignores changes whose lines are all blank
upgrade generates git diffs to avoid data loss upgrade generates git diffs to avoid data loss
''' '''
_HAS_DYNAMIC_ATTRIBUTES = True
defaults = { defaults = {
b'context': 3, b'context': 3,
b'text': False, b'text': False,
b'showfunc': False, b'showfunc': False,
b'git': False, b'git': False,
b'nodates': False, b'nodates': False,
b'nobinary': False, b'nobinary': False,
b'noprefix': False, b'noprefix': False,