( )⚙ D7286 match: suppress error about subscripting an exception

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7286

match: suppress error about subscripting an exception
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:58 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG6ff196d2553b: match: suppress error about subscripting an exception
Summary

I get the sense I should file a bug about subscripting Exception subclasses.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 6 2019, 5:58 PM
durin42 updated this revision to Diff 17671.Nov 6 2019, 6:23 PM
indygreg accepted this revision.Nov 7 2019, 3:20 AM
indygreg added a subscriber: indygreg.

Regarding filing a bug, ISTR exception subscription is deprecated (or at least discouraged) in modern Python versions: I believe you are encouraged to access e.g. e.message now. But I'm fine suppressing these for now until Python formally deprecates it by emitting a DeprecationWarning.

This revision is now accepted and ready to land.Nov 7 2019, 3:21 AM
durin42 added a commit: rHG6ff196d2553b: match: suppress error about subscripting an exception.Nov 7 2019, 3:34 AM
Closed by commit rHG6ff196d2553b: match: suppress error about subscripting an exception (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/match.py (4 lines)

Diff 17656

mercurial/match.py

try: try:
fullpath = os.path.join(root, util.localpath(pat)) fullpath = os.path.join(root, util.localpath(pat))
includepats = readpatternfile(fullpath, warn) includepats = readpatternfile(fullpath, warn)
for k, p, source in _donormalize( for k, p, source in _donormalize(
includepats, default, root, cwd, auditor, warn includepats, default, root, cwd, auditor, warn
): ):
kindpats.append((k, p, source or pat)) kindpats.append((k, p, source or pat))
except error.Abort as inst: except error.Abort as inst:
raise error.Abort(b'%s: %s' % (pat, inst[0])) raise error.Abort(
b'%s: %s' % (pat, inst[0])
) # pytype: disable=unsupported-operands
except IOError as inst: except IOError as inst:
if warn: if warn:
warn( warn(
_(b"skipping unreadable pattern file '%s': %s\n") _(b"skipping unreadable pattern file '%s': %s\n")
% (pat, stringutil.forcebytestr(inst.strerror)) % (pat, stringutil.forcebytestr(inst.strerror))
) )
continue continue
# else: re or relre - which cannot be normalized # else: re or relre - which cannot be normalized