( )⚙ D7286 match: suppress error about subscripting an exception

This is an archive of the discontinued Mercurial Phabricator instance.

match: suppress error about subscripting an exception
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:58 PM.

Details

Summary

I get the sense I should file a bug about subscripting Exception subclasses.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 6 2019, 5:58 PM
durin42 updated this revision to Diff 17671.Nov 6 2019, 6:23 PM
indygreg accepted this revision.Nov 7 2019, 3:20 AM
indygreg added a subscriber: indygreg.

Regarding filing a bug, ISTR exception subscription is deprecated (or at least discouraged) in modern Python versions: I believe you are encouraged to access e.g. e.message now. But I'm fine suppressing these for now until Python formally deprecates it by emitting a DeprecationWarning.

This revision is now accepted and ready to land.Nov 7 2019, 3:21 AM
This revision was automatically updated to reflect the committed changes.