( )⚙ D7332 index: use `index.get_rev` in `phases.newheads`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7332

index: use `index.get_rev` in `phases.newheads`
ClosedPublic

Authored by marmoute on Nov 8 2019, 11:24 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG505a2bc53759: index: use `index.get_rev` in `phases.newheads`
rHG1628cb02959f: index: use `index.get_rev` in `phases.newheads`
rHGd294f0baf549: index: use `index.get_rev` in `phases.newheads`

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Nov 8 2019, 11:24 AM
indygreg accepted this revision.Nov 8 2019, 3:13 PM
This revision is now accepted and ready to land.Nov 8 2019, 3:13 PM
martinvonz added a subscriber: martinvonz.Nov 9 2019, 3:30 AM

nit: should be get_rev, not has_node in the commit message

marmoute edited parent revisions, added: D7327: index: use `index.get_rev` in `localrepo.known`; removed: D7331: index: use `index.has_node` in `phases.filterunknown`.Nov 9 2019, 8:14 AM
marmoute retitled this revision from index: use `index.has_node` in `phases.newheads` to index: use `index.get_rev` in `phases.newheads`.
marmoute added a child revision: D7335: index: use `index.get_rev` in `obsutil.getobsoleted`.
marmoute added a commit: rHGd294f0baf549: index: use `index.get_rev` in `phases.newheads`.Nov 9 2019, 10:57 AM
Closed by commit rHGd294f0baf549: index: use `index.get_rev` in `phases.newheads` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/phases.py (2 lines)

Diff 17893

mercurial/phases.py

* `heads`: define the first subset * `heads`: define the first subset
* `roots`: define the second we subtract from the first""" * `roots`: define the second we subtract from the first"""
# prevent an import cycle # prevent an import cycle
# phases > dagop > patch > copies > scmutil > obsolete > obsutil > phases # phases > dagop > patch > copies > scmutil > obsolete > obsutil > phases
from . import dagop from . import dagop
repo = repo.unfiltered() repo = repo.unfiltered()
cl = repo.changelog cl = repo.changelog
rev = cl.nodemap.get rev = cl.index.get_rev
if not roots: if not roots:
return heads return heads
if not heads or heads == [nullid]: if not heads or heads == [nullid]:
return [] return []
# The logic operated on revisions, convert arguments early for convenience # The logic operated on revisions, convert arguments early for convenience
new_heads = set(rev(n) for n in heads if n != nullid) new_heads = set(rev(n) for n in heads if n != nullid)
roots = [rev(n) for n in roots] roots = [rev(n) for n in roots]
# compute the area we need to remove # compute the area we need to remove