( )⚙ D7351 index: use `index.has_node` in `histedit._finishhistedit

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7351

index: use `index.has_node` in `histedit._finishhistedit
ClosedPublic

Authored by marmoute on Nov 8 2019, 11:26 AM.

Details

Reviewers
durin42
indygreg
Group Reviewers
hg-reviewers
Commits
rHG2b5d07702f94: index: use `index.has_node` in `histedit._finishhistedit
rHGac6414f2d877: index: use `index.has_node` in `histedit._finishhistedit

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (4 lines)

Diff 17877

hgext/histedit.py

else: else:
mapping = {} mapping = {}
for n in tmpnodes: for n in tmpnodes:
if n in repo: if n in repo:
mapping[n] = () mapping[n] = ()
# remove entries about unknown nodes # remove entries about unknown nodes
nodemap = repo.unfiltered().changelog.nodemap has_node = repo.unfiltered().changelog.index.has_node
mapping = { mapping = {
k: v k: v
for k, v in mapping.items() for k, v in mapping.items()
if k in nodemap and all(n in nodemap for n in v) if has_node(k) and all(has_node(n) for n in v)
} }
scmutil.cleanupnodes(repo, mapping, b'histedit') scmutil.cleanupnodes(repo, mapping, b'histedit')
hf = fm.hexfunc hf = fm.hexfunc
fl = fm.formatlist fl = fm.formatlist
fd = fm.formatdict fd = fm.formatdict
nodechanges = fd( nodechanges = fd(
{ {
hf(oldn): fl([hf(n) for n in newn], name=b'node') hf(oldn): fl([hf(n) for n in newn], name=b'node')