Page MenuHomePhabricator

status: split morestatus data loading from display
ClosedPublic

Authored by rdamazio on Dec 10 2019, 1:39 AM.

Details

Summary

This is a small refactoring in preparation for adding more morestatus
functionality (notably for templated/JSON output) - the goal is to
use the data inside the status display loop, as well as output the
overall state in a templatable/structured way.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rdamazio created this revision.Dec 10 2019, 1:39 AM
pulkit accepted this revision.Dec 10 2019, 8:15 AM
This revision is now accepted and ready to land.Dec 10 2019, 8:15 AM

I pushed @martinvonz D7591, so these need to be rebased. Thanks!

I pushed @martinvonz D7591, so these need to be rebased. Thanks!

Are you asking me to do something, or are you going to?
This supersedes his change completely.

rdamazio updated this revision to Diff 18586.Dec 10 2019, 1:15 PM

Just phabsended after a rebase onto hg-committed, let me know if that's not what you expected.

I pushed @martinvonz D7591, so these need to be rebased. Thanks!

Are you asking me to do something, or are you going to?
This supersedes his change completely.

He's asking you to rebase this series. Pull from http://mercurial-scm.org/repo/hg-committed and then rebase on top of @.

Even if my patch had not been queued, I would have preferred if you had split that change out from this patch since it's a separate change from what the commit message says.

I pushed @martinvonz D7591, so these need to be rebased. Thanks!

Are you asking me to do something, or are you going to?
This supersedes his change completely.

He's asking you to rebase this series. Pull from http://mercurial-scm.org/repo/hg-committed and then rebase on top of @.
Even if my patch had not been queued, I would have preferred if you had split that change out from this patch since it's a separate change from what the commit message says.

Thanks. Yes, that's what I did :)

This revision was automatically updated to reflect the committed changes.