This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7654

rust-index: add a `inner` method to the Index struct
ClosedPublic

Authored by marmoute on Dec 13 2019, 3:11 PM.

Details

Reviewers
Alphare
indygreg
Group Reviewers
hg-reviewers
Commits
rHGab3fd8077f5e: rust-index: add a `inner` method to the Index struct
Summary

We are about to introduce a Rust wrapper to the C index. It will be exposed as a
Python object. As a start all call will be forwarded to an internal index object
(as used now).

For this forwarding to works, we need to access that index object (from the C
extensions). We adds a method doing to on the existing Index rust struct.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Dec 13 2019, 3:11 PM
Alphare accepted this revision.Dec 20 2019, 3:38 AM
indygreg accepted this revision.Dec 23 2019, 12:56 PM
This revision is now accepted and ready to land.Dec 23 2019, 12:56 PM
gracinet added a commit: rHGab3fd8077f5e: rust-index: add a `inner` method to the Index struct.Dec 23 2019, 1:07 PM
Closed by commit rHGab3fd8077f5e: rust-index: add a `inner` method to the Index struct (authored by gracinet). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-cpython/src/cindex.rs (5 lines)

Diff 18919

rust/hg-cpython/src/cindex.rs

impl Index { impl Index {
pub fn new(py: Python, index: PyObject) -> PyResult<Self> { pub fn new(py: Python, index: PyObject) -> PyResult<Self> {
Ok(Index { Ok(Index {
index: index, index: index,
capi: unsafe { revlog_capi::retrieve(py)? }, capi: unsafe { revlog_capi::retrieve(py)? },
}) })
} }
/// return a reference to the CPython Index object in this Struct
pub fn inner(&self) -> &PyObject {
&self.index
}
} }
impl Clone for Index { impl Clone for Index {
fn clone(&self) -> Self { fn clone(&self) -> Self {
let guard = Python::acquire_gil(); let guard = Python::acquire_gil();
Index { Index {
index: self.index.clone_ref(guard.python()), index: self.index.clone_ref(guard.python()),
capi: self.capi, capi: self.capi,