Details
Details
- Reviewers
marmoute - Group Reviewers
hg-reviewers - Commits
- rHGc443b9ba6f63: py3: __repr__ needs to return str, not bytes
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
mercurial/bundle2.py | ||
---|---|---|
1018 | Aren't self.__class__.__module__ and self.__class__.__name__ str? |
mercurial/bundle2.py | ||
---|---|---|
1018 | Yep, so this instance fails for other reasons as well. Sigh. I've sent a followup (D8091). This may cause output like <foo object at 0xabcd1234; id: b'id'; type: b'type'; mandatory: True>. I didn't actually test most of these, obviously :P I just did a grep for repr returning bytes... |
Aren't self.__class__.__module__ and self.__class__.__name__ str?