( )⚙ D8173 nodemap: warm the persistent nodemap on disk with debugupdatecache

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8173

nodemap: warm the persistent nodemap on disk with debugupdatecache
ClosedPublic

Authored by marmoute on Feb 27 2020, 4:09 AM.

Details

Reviewers
indygreg
pulkit
Group Reviewers
hg-reviewers
Commits
rHG336ec75ed1ac: nodemap: warm the persistent nodemap on disk with debugupdatecache
Summary

When appropriate, the nodemap cache file will be created.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

Diff 20354

mercurial/localrepo.py

if tr is None or tr.changes[b'origrepolen'] < len(self): if tr is None or tr.changes[b'origrepolen'] < len(self):
# accessing the 'ser ved' branchmap should refresh all the others, # accessing the 'ser ved' branchmap should refresh all the others,
self.ui.debug(b'updating the branch cache\n') self.ui.debug(b'updating the branch cache\n')
self.filtered(b'served').branchmap() self.filtered(b'served').branchmap()
self.filtered(b'served.hidden').branchmap() self.filtered(b'served.hidden').branchmap()
if full: if full:
unfi = self.unfiltered() unfi = self.unfiltered()
self.changelog.update_caches(transaction=tr)
rbc = unfi.revbranchcache() rbc = unfi.revbranchcache()
for r in unfi.changelog: for r in unfi.changelog:
rbc.branchinfo(r) rbc.branchinfo(r)
rbc.write() rbc.write()
# ensure the working copy parents are in the manifestfulltextcache # ensure the working copy parents are in the manifestfulltextcache
for ctx in self[b'.'].parents(): for ctx in self[b'.'].parents():
ctx.manifest() # accessing the manifest is enough ctx.manifest() # accessing the manifest is enough

mercurial/revlog.py

# could have a same revlog node with different flags (i.e. different # could have a same revlog node with different flags (i.e. different
# rawtext contents) and the delta could be incompatible. # rawtext contents) and the delta could be incompatible.
if (self.flags(baserev) & REVIDX_RAWTEXT_CHANGING_FLAGS) or ( if (self.flags(baserev) & REVIDX_RAWTEXT_CHANGING_FLAGS) or (
self.flags(rev) & REVIDX_RAWTEXT_CHANGING_FLAGS self.flags(rev) & REVIDX_RAWTEXT_CHANGING_FLAGS
): ):
return False return False
return True return True
def update_caches(self, transaction):
if self.nodemap_file is not None:
if transaction is None:
nodemaputil.update_persistent_nodemap(self)
else:
nodemaputil.setup_persistent_nodemap(transaction, self)
def clearcaches(self): def clearcaches(self):
self._revisioncache = None self._revisioncache = None
self._chainbasecache.clear() self._chainbasecache.clear()
self._chunkcache = (0, b'') self._chunkcache = (0, b'')
self._pcache = {} self._pcache = {}
self.index.clearcaches() self.index.clearcaches()
def rev(self, node): def rev(self, node):

mercurial/revlogutils/nodemap.py

""" """
if revlog._inline: if revlog._inline:
return # inlined revlog are too small for this to be relevant return # inlined revlog are too small for this to be relevant
if revlog.nodemap_file is None: if revlog.nodemap_file is None:
return # we do not use persistent_nodemap on this revlog return # we do not use persistent_nodemap on this revlog
callback_id = b"revlog-persistent-nodemap-%s" % revlog.nodemap_file callback_id = b"revlog-persistent-nodemap-%s" % revlog.nodemap_file
if tr.hasfinalize(callback_id): if tr.hasfinalize(callback_id):
return # no need to register again return # no need to register again
tr.addfinalize(callback_id, lambda tr: _persist_nodemap(tr, revlog)) tr.addfinalize(
callback_id, lambda tr: _persist_nodemap(tr.addpostclose, revlog)
)
def update_persistent_nodemap(revlog):
"""update the persistent nodemap right now
To be used for updating the nodemap on disk outside of a normal transaction
setup (eg, `debugupdatecache`).
"""
cleanups = []
_persist_nodemap((lambda x, y: cleanups.append(y)), revlog)
for c in cleanups:
c(None)
def _persist_nodemap(tr, revlog): def _persist_nodemap(cleaner, revlog):
"""Write nodemap data on disk for a given revlog """Write nodemap data on disk for a given revlog
""" """
if getattr(revlog, 'filteredrevs', ()): if getattr(revlog, 'filteredrevs', ()):
raise error.ProgrammingError( raise error.ProgrammingError(
"cannot persist nodemap of a filtered changelog" "cannot persist nodemap of a filtered changelog"
) )
if revlog.nodemap_file is None: if revlog.nodemap_file is None:
msg = "calling persist nodemap on a revlog without the feature enableb" msg = "calling persist nodemap on a revlog without the feature enableb"
if olds: if olds:
realvfs = getattr(revlog, '_realopener', revlog.opener) realvfs = getattr(revlog, '_realopener', revlog.opener)
def cleanup(tr): def cleanup(tr):
for oldfile in olds: for oldfile in olds:
realvfs.tryunlink(oldfile) realvfs.tryunlink(oldfile)
callback_id = b"revlog-cleanup-nodemap-%s" % revlog.nodemap_file callback_id = b"revlog-cleanup-nodemap-%s" % revlog.nodemap_file
tr.addpostclose(callback_id, cleanup) cleaner(callback_id, cleanup)
### Nodemap docket file ### Nodemap docket file
# #
# The nodemap data are stored on disk using 2 files: # The nodemap data are stored on disk using 2 files:
# #
# * a raw data files containing a persistent nodemap # * a raw data files containing a persistent nodemap
# (see `Nodemap Trie` section) # (see `Nodemap Trie` section)

tests/test-persistent-nodemap.t

$ hg debugnodemap --metadata $ hg debugnodemap --metadata
uid: ???????????????? (glob) uid: ???????????????? (glob)
tip-rev: 5002 tip-rev: 5002
data-length: 122944 data-length: 122944
data-unused: 0 data-unused: 0
$ f --sha256 .hg/store/00changelog-*.nd --size $ f --sha256 .hg/store/00changelog-*.nd --size
.hg/store/00changelog-????????????????.nd: size=122944, sha256=755976b22b64ab680401b45395953504e64e7fa8c31ac570f58dee21e15f9bc0 (glob) .hg/store/00changelog-????????????????.nd: size=122944, sha256=755976b22b64ab680401b45395953504e64e7fa8c31ac570f58dee21e15f9bc0 (glob)
#endif #endif
Test force warming the cache
$ rm .hg/store/00changelog.n
$ hg debugnodemap --metadata
$ hg debugupdatecache
#if pure
$ hg debugnodemap --metadata
uid: ???????????????? (glob)
tip-rev: 5002
data-length: 122944
data-unused: 0
#else
$ hg debugnodemap --metadata
uid: ???????????????? (glob)
tip-rev: 5002
data-length: 122944
data-unused: 0
#endif