This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8181

nodemap: add a todo list for getting out of experimental
ClosedPublic

Authored by marmoute on Feb 28 2020, 1:54 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHG15a033cabc19: nodemap: add a todo list for getting out of experimental

Summary

This is all the requirement I can think off. More might be added as they emerge.

The first ones are mostly simple technical matters that will be taken care of
soon. The question about the "status" of the persistent nodemap and the revlogs
that will use it requires more discussion and thinking.

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

marmoute created this revision.Feb 28 2020, 1:54 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptFeb 28 2020, 1:54 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

marmoute added a child revision: D8182: nodemap: document the docket attributes.Feb 28 2020, 1:54 PM

eventless rebase past D8255

marmoute added a child revision: D8183: nodemap: test that an outdated nodemap can catch up.Mar 10 2020, 9:35 PM

marmoute added a commit: rHG15a033cabc19: nodemap: add a todo list for getting out of experimental.Mar 11 2020, 11:43 AM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHG15a033cabc19: nodemap: add a todo list for getting out of experimental (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/configitems.py (17 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	20384		Feb 28 2020, 1:54 PM	★	★
Diff 2	20580		Mar 6 2020, 6:36 PM	★	★
Diff 3	20702	rHG15a033cabc19703e38b7107679dd9548832593c3	Feb 27 2020, 9:42 AM	★	★

Commit	Parents	Author	Summary	Date
85d94bb7cdf3	83d507e5360c	Pierre-Yves David		Feb 27 2020, 9:42 AM

Status	Author	Revision
Closed	marmoute	D8193 nodemap: automatically "vacuum" the persistent nodemap when too sparse
Closed	marmoute	D8192 nodemap: display percentage of unused in `hg debugnodemap`
Closed	marmoute	D8191 nodemap: make sure on disk change get rolled back with the transaction
Closed	marmoute	D8190 nodemap: test that concurrent process don't see the pending transaction
Closed	marmoute	D8316 testlib: adjust wait-on-file timeout according to the global test timeout
Closed	marmoute	D8189 testlib: add a small scrip to help process to synchronise using file
Closed	marmoute	D8188 nodemap: make sure the nodemap docket is updated after the changelog
Closed	marmoute	D8187 nodemap: make sure hooks have access to an up-to-date version
Closed	marmoute	D8186 nodemap: deal with the "debugupdatecache" case using a "fake" transaction
Closed	marmoute	D8185 changelog: change the implementation of `_divertopenener`
Closed	marmoute	D8184 nodemap: track the tip_node for validation
Closed	marmoute	D8183 nodemap: test that an outdated nodemap can catch up
Closed	Alphare	D8162 hghave: add a `rust` keyword to detect the use of compiled rust code
Closed	marmoute	D8180 nodemap: check that a simple lookup works fine
Closed	marmoute	D8182 nodemap: document the docket attributes
Closed	marmoute	D8181 nodemap: add a todo list for getting out of experimental
Closed	Alphare	D8164 rust-nodemap: automatically use the rust index for persistent nodemap
Closed	Alphare	D8163 nodemap: use data from the index in debugnodemap --dump-new
Closed	Alphare	D8161 rust-nodemap: also clear Rust data in `clearcaches`
Closed	Alphare	D8160 rust-nodemap: add binding to `nodemap_update_data`
Closed	Alphare	D8159 rust-nodemap: add binding for `nodemap_data_incremental`
Closed	Alphare	D8158 rust-nodemap: add binding for `nodemap_data_all`
Closed	Alphare	D8157 rust-nodemap: use proper Index API instead of using the C API
Closed	Alphare	D8156 rust-nodemap: add utils for propagating errors
Closed	Alphare	D8155 rust-nodemap: add utils to create `Node`s from Python objects
Closed	Alphare	D8154 rust-index: add `append` method to cindex/Index
Closed	Alphare	D8153 rust-index: moved constructor in separate impl block
Closed	Alphare	D8152 revlog: using two new functions in C capsule from Rust code
Closed	marmoute	D8174 nodemap: refresh the persistent data on nodemap creation
Closed	marmoute	D8173 nodemap: warm the persistent nodemap on disk with debugupdatecache

Diff 20384

mercurial/configitems.py

	b'devel', b'disableloaddefaultcerts', default=False,			b'devel', b'disableloaddefaultcerts', default=False,
	)			)
	coreconfigitem(			coreconfigitem(
	b'devel', b'warn-empty-changegroup', default=False,			b'devel', b'warn-empty-changegroup', default=False,
	)			)
	coreconfigitem(			coreconfigitem(
	b'devel', b'legacy.exchange', default=list,			b'devel', b'legacy.exchange', default=list,
	)			)
				# TODO before getting `persistent-nodemap` out of experimental
				#
				# * code/tests around aborted transaction
				# * code/tests around pending data for hooks
				# * code/tests around detection of invalid cache
				# (eg: after strip from an incompatible client)
				# * regenerate a new nodemap when the unused/total ration is to high
				# * decide for a "status" of the persistent nodemap and associated location
				# - part of the store next the revlog itself (new requirements)
				# - part of the cache directory
				# - part of an `index` directory
				# (https://www.mercurial-scm.org/wiki/ComputedIndexPlan)
				# * do we want to use this for more than just changelog? if so we need:
				# - simpler "pending" logic for them
				# - double check the memory story (we dont want to keep all revlog in memory)
				# - think about the naming scheme if we are in "cache"
				# * increment the version format to "1" and freeze it.
	coreconfigitem(			coreconfigitem(
	b'devel', b'persistent-nodemap', default=False,			b'devel', b'persistent-nodemap', default=False,
	)			)
	coreconfigitem(			coreconfigitem(
	b'devel', b'servercafile', default=b'',			b'devel', b'servercafile', default=b'',
	)			)
	coreconfigitem(			coreconfigitem(
	b'devel', b'serverexactprotocol', default=b'',			b'devel', b'serverexactprotocol', default=b'',