This is an archive of the discontinued Mercurial Phabricator instance.

fix: mark -r as advanced
ClosedPublic

Authored by martinvonz on Mar 13 2020, 3:33 PM.

Details

Summary

See the previous patch for reasoning. I planned to even mark it
deprecated, but someone (timeless?) on the #mercurial IRC channel said
they sometimes wanted to use -r with its existing semantics.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 13 2020, 3:33 PM
martinvonz updated this revision to Diff 20777.Mar 13 2020, 3:38 PM
mharbison72 accepted this revision.Mar 13 2020, 6:41 PM
martinvonz updated this revision to Diff 20781.Mar 13 2020, 7:24 PM

For the record, I always use hg fix with --rev.

martinvonz updated this revision to Diff 20823.Mar 18 2020, 2:34 AM
durin42 accepted this revision.Mar 18 2020, 11:56 AM
durin42 added a subscriber: durin42.

For the record, I always use hg fix with --rev.

So do I, but I also acknowledge that I've got some idiosyncratic habits and use of -r is definitely correlated with users that get confused and blow a foot partway off.

This revision is now accepted and ready to land.Mar 18 2020, 11:56 AM
pulkit accepted this revision.Mar 19 2020, 4:15 AM
This revision was automatically updated to reflect the committed changes.