This is an archive of the discontinued Mercurial Phabricator instance.

upgrade: support the --quiet flag
ClosedPublic

Authored by marmoute on Apr 15 2020, 4:16 PM.

Details

Summary

The command is currently very verbose with a various bit of output being time
sensitive or randomized. The make invocation bulky and hard to match in the
test. We move various message from ui.write to ui.status in order for the
--quiet flag to have effect and helps the situation.

As a side benefit, we can replace the various redirection to > /dev/null with the --quiet flag.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 15 2020, 4:16 PM
mharbison72 accepted this revision.Apr 16 2020, 12:05 AM
mharbison72 added a subscriber: mharbison72.

I think it might make sense to make some of these messages note() or debug(), but this is still an improvement.

pulkit accepted this revision.Apr 16 2020, 4:21 AM
This revision is now accepted and ready to land.Apr 16 2020, 4:21 AM
Alphare accepted this revision.May 7 2020, 9:21 AM
This revision was automatically updated to reflect the committed changes.