Page MenuHomePhabricator

rust-chg: reimplement attach_io operation as async function
ClosedPublic

Authored by yuja on Apr 16 2020, 8:30 AM.

Details

Summary

In short, MessageLoop<Connection> was redesigned as Protocol<Connection>,
and the protocol methods no longer consume self.

API changes are briefly documented in the following page:
https://docs.rs/tokio-hglib/0.3.0/tokio_hglib/struct.Protocol.html

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuja created this revision.Apr 16 2020, 8:30 AM
Alphare accepted this revision.Apr 17 2020, 7:58 AM
Alphare added a subscriber: Alphare.

It's impressive how easier to reason about this all becomes.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.