Page MenuHomePhabricator

rust-chg: modernize entry function
ClosedPublic

Authored by yuja on Apr 16 2020, 8:30 AM.

Details

Summary

Finally the entire build passes.

There's a bug that run() no longer waits for the spawned pager, which will
be fixed by the next patch.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuja created this revision.Apr 16 2020, 8:30 AM
durin42 added inline comments.
rust/chg/src/main.rs
70

With this series I get lots of

+ error[E0670]: async fn` is not permitted in the 2015 edition`

from test-check-rust-format.t. Am I doing something wrong?

yuja added a comment.Apr 17 2020, 6:47 AM

+ error[E0670]: async fn` is not permitted in the 2015 edition`

Appears that we need to specify --edition=2018. Sent patch.

Alphare accepted this revision.Apr 17 2020, 8:31 AM
In D8448#126114, @yuja wrote:

+ error[E0670]: async fn` is not permitted in the 2015 edition`

Appears that we need to specify --edition=2018. Sent patch.

Patch was sent, the series looks ready to land.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.