Page MenuHomePhabricator

rust-chg: have attach_io() simply take reference of AsRawFd object
ClosedPublic

Authored by yuja on Apr 16 2020, 8:30 AM.

Details

Summary

We no longer have to deal with the restriction of the Future type.
Before, these file objects couldn't be references and that's the only
reason why we had to make stderr an Option<T>.

This fixes future type deduction issue of stderr = None, where rustc would
complain that T of Option<T> couldn't be deduced.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuja created this revision.Apr 16 2020, 8:30 AM
Alphare accepted this revision.Apr 17 2020, 7:59 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.