Page MenuHomePhabricator

rust-chg: reimplement ChgClientExt as ChgClient wrapper
ClosedPublic

Authored by yuja on Apr 16 2020, 8:30 AM.

Details

Summary

ChgClient is no longer an extension trait because:

a. Client object is not consumed and recreated in future-0.3 world, which

unblocks writing a simple wrapper struct.

b. async fn isn't allowed in trait.

Overall, the API should become simpler.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuja created this revision.Apr 16 2020, 8:30 AM
Alphare accepted this revision.Apr 17 2020, 8:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.