Page MenuHomePhabricator

copies: move `merged` testing sooner
ClosedPublic

Authored by marmoute on Thu, Oct 1, 10:09 AM.

Details

Summary

previously is_merged was an expensive callback. Now that all this data is
pre-computed, this is is a simple membership testing.

So it is probably cheaper than the membership testing.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Thu, Oct 1, 10:09 AM
marmoute updated this revision to Diff 22999.Fri, Oct 2, 5:10 AM
Alphare accepted this revision.Fri, Oct 2, 9:16 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.