This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9092

changing-files: retrieve changelogrevision.files from the sidedata block
ClosedPublic

Authored by marmoute on Sep 26 2020, 8:10 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Commits
rHG053c9014fd39: changing-files: retrieve changelogrevision.files from the sidedata block
Summary

The files field is know to have issue, using a list with fixed, and fixable,
computation can only help. For example, using a fixes files field would be
enough to fix issue6219 once this feature get usable in production.

We focus on having thing working for now, we will deal with performance later.
Right now we have a ironic situation were we parse sorted value from disk to
turn them into a set and then having to sort it again.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/changelog.py (2 lines)

Diff 23047

mercurial/changelog.py

p1_copies=self.p1copies or {}, p1_copies=self.p1copies or {},
p2_copies=self.p2copies or {}, p2_copies=self.p2copies or {},
) )
self._changes = changes self._changes = changes
return changes return changes
@property @property
def files(self): def files(self):
if self._cpsd:
return sorted(self.changes.touched)
off = self._offsets off = self._offsets
if off[2] == off[3]: if off[2] == off[3]:
return [] return []
return self._text[off[2] + 1 : off[3]].split(b'\n') return self._text[off[2] + 1 : off[3]].split(b'\n')
@property @property
def filesadded(self): def filesadded(self):