This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9091

changing-files: drop the now useless changelogrevision argument
ClosedPublic

Authored by marmoute on Sep 26 2020, 8:10 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Commits
rHG9003e6524f78: changing-files: drop the now useless changelogrevision argument
Summary

Since all filename are now included in the sidedata block, we no longer need to decode the files from the revision.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/changelog.py (2 lines)
Mmercurial/metadata.py (2 lines)

Diff 23046

mercurial/changelog.py

return decodeextra(raw) return decodeextra(raw)
@property @property
def changes(self): def changes(self):
if self._changes is not None: if self._changes is not None:
return self._changes return self._changes
if self._cpsd: if self._cpsd:
changes = metadata.decode_files_sidedata(self, self._sidedata) changes = metadata.decode_files_sidedata(self._sidedata)
else: else:
changes = metadata.ChangingFiles( changes = metadata.ChangingFiles(
touched=self.files or (), touched=self.files or (),
added=self.filesadded or (), added=self.filesadded or (),
removed=self.filesremoved or (), removed=self.filesremoved or (),
p1_copies=self.p1copies or {}, p1_copies=self.p1copies or {},
p2_copies=self.p2copies or {}, p2_copies=self.p2copies or {},
) )

mercurial/metadata.py

copy = files.copied_from_p2.get(f) copy = files.copied_from_p2.get(f)
flag |= COPIED_FROM_P2_FLAG flag |= COPIED_FROM_P2_FLAG
copy_idx = file_idx[copy] copy_idx = file_idx[copy]
chunks.append(INDEX_ENTRY.pack(flag, filename_length, copy_idx)) chunks.append(INDEX_ENTRY.pack(flag, filename_length, copy_idx))
chunks.extend(all_files) chunks.extend(all_files)
return {sidedatamod.SD_FILES: b''.join(chunks)} return {sidedatamod.SD_FILES: b''.join(chunks)}
def decode_files_sidedata(changelogrevision, sidedata): def decode_files_sidedata(sidedata):
md = ChangingFiles() md = ChangingFiles()
raw = sidedata.get(sidedatamod.SD_FILES) raw = sidedata.get(sidedatamod.SD_FILES)
if raw is None: if raw is None:
return md return md
copies = [] copies = []
all_files = [] all_files = []