This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9126

changing-files: add clean computation of changed files for roots
ClosedPublic

Authored by marmoute on Sep 30 2020, 9:11 AM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf6811e5bd994: changing-files: add clean computation of changed files for roots
rHG38613f6faa32: changing-files: add clean computation of changed files for roots
rHG876df4613aa1: changing-files: add clean computation of changed files for roots
Summary

The files field is not reliable, so we need to compute things from scratch. We
start with the simplest case root changesets. In the beginning they was nothing,
then user said "let there be files" and there were added files.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/metadata.py (15 lines)

Diff 23090

mercurial/metadata.py

def update_copies_from_p2(self, copies): def update_copies_from_p2(self, copies):
for dest, source in copies.items(): for dest, source in copies.items():
self.mark_copied_from_p2(source, dest) self.mark_copied_from_p2(source, dest)
def compute_all_files_changes(ctx): def compute_all_files_changes(ctx):
"""compute the files changed by a revision""" """compute the files changed by a revision"""
p1 = ctx.p1()
p2 = ctx.p2()
if p1.rev() == node.nullrev and p2.rev() == node.nullrev:
return _process_root(ctx)
filescopies = computechangesetcopies(ctx) filescopies = computechangesetcopies(ctx)
filesadded = computechangesetfilesadded(ctx) filesadded = computechangesetfilesadded(ctx)
filesremoved = computechangesetfilesremoved(ctx) filesremoved = computechangesetfilesremoved(ctx)
filesmerged = computechangesetfilesmerged(ctx) filesmerged = computechangesetfilesmerged(ctx)
files = ChangingFiles() files = ChangingFiles()
files.update_touched(ctx.files()) files.update_touched(ctx.files())
files.update_added(filesadded) files.update_added(filesadded)
files.update_removed(filesremoved) files.update_removed(filesremoved)
files.update_merged(filesmerged) files.update_merged(filesmerged)
files.update_copies_from_p1(filescopies[0]) files.update_copies_from_p1(filescopies[0])
files.update_copies_from_p2(filescopies[1]) files.update_copies_from_p2(filescopies[1])
return files return files
def _process_root(ctx):
"""compute the appropriate changed files for a changeset with no parents
"""
# Simple, there was nothing before it, so everything is added.
md = ChangingFiles()
manifest = ctx.manifest()
for filename in manifest:
md.mark_added(filename)
return md
def computechangesetfilesadded(ctx): def computechangesetfilesadded(ctx):
"""return the list of files added in a changeset """return the list of files added in a changeset
""" """
added = [] added = []
for f in ctx.files(): for f in ctx.files():
if not any(f in p for p in ctx.parents()): if not any(f in p for p in ctx.parents()):
added.append(f) added.append(f)
return added return added