This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9578

upgrade: move printing of unused optimizations to UpgradeOperation class
ClosedPublic

Authored by pulkit on Dec 14 2020, 4:55 AM.

Details

Reviewers
mharbison72
Group Reviewers
hg-reviewers
Commits
rHG25d11b24dedf: upgrade: move printing of unused optimizations to UpgradeOperation class

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

Diff 24297

mercurial/upgrade.py

) )
) )
upgrade_op.print_requirements() upgrade_op.print_requirements()
upgrade_op.print_optimisations() upgrade_op.print_optimisations()
upgrade_op.print_upgrade_actions() upgrade_op.print_upgrade_actions()
upgrade_op.print_affected_revlogs() upgrade_op.print_affected_revlogs()
unusedoptimize = [i for i in alloptimizations if i not in actions] if upgrade_op.unused_optimizations:
if unusedoptimize:
ui.status( ui.status(
_( _(
b'additional optimizations are available by specifying ' b'additional optimizations are available by specifying '
b'"--optimize <name>":\n\n' b'"--optimize <name>":\n\n'
) )
) )
for i in unusedoptimize: upgrade_op.print_unused_optimizations()
ui.status(_(b'%s\n %s\n\n') % (i.name, i.description))
return return
# Else we're in the run=true case. # Else we're in the run=true case.
ui.write(_(b'upgrade will perform the following actions:\n\n')) ui.write(_(b'upgrade will perform the following actions:\n\n'))
upgrade_op.print_requirements() upgrade_op.print_requirements()
upgrade_op.print_optimisations() upgrade_op.print_optimisations()
upgrade_op.print_upgrade_actions() upgrade_op.print_upgrade_actions()
upgrade_op.print_affected_revlogs() upgrade_op.print_affected_revlogs()

mercurial/upgrade_utils/actions.py

# requirements which will be removed by the operation # requirements which will be removed by the operation
self.removed_requirements = ( self.removed_requirements = (
self.current_requirements - self.new_requirements self.current_requirements - self.new_requirements
) )
# requirements which will be preserved by the operation # requirements which will be preserved by the operation
self.preserved_requirements = ( self.preserved_requirements = (
self.current_requirements & self.new_requirements self.current_requirements & self.new_requirements
) )
# optimizations which are not used and it's recommended that they
# should use them
all_optimizations = findoptimizations(None)
self.unused_optimizations = [
i for i in all_optimizations if i not in self.actions
]
def _write_labeled(self, l, label): def _write_labeled(self, l, label):
""" """
Utility function to aid writing of a list under one label Utility function to aid writing of a list under one label
""" """
first = True first = True
for r in sorted(l): for r in sorted(l):
if not first: if not first:
if not self.revlogs_to_process: if not self.revlogs_to_process:
self.ui.write((b'no revlogs to process\n')) self.ui.write((b'no revlogs to process\n'))
else: else:
self.ui.write((b'processed revlogs:\n')) self.ui.write((b'processed revlogs:\n'))
for r in sorted(self.revlogs_to_process): for r in sorted(self.revlogs_to_process):
self.ui.write((b' - %s\n' % r)) self.ui.write((b' - %s\n' % r))
self.ui.write((b'\n')) self.ui.write((b'\n'))
def print_unused_optimizations(self):
for i in self.unused_optimizations:
self.ui.status(_(b'%s\n %s\n\n') % (i.name, i.description))
def has_action(self, name): def has_action(self, name):
""" Check whether the upgrade operation will perform this action """ """ Check whether the upgrade operation will perform this action """
return name in self._actions_names return name in self._actions_names
### Code checking if a repository can got through the upgrade process at all. # ### Code checking if a repository can got through the upgrade process at all. #