This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9771

actions: calculate what all parts does the operation touches
ClosedPublic

Authored by pulkit on Jan 14 2021, 7:54 AM.

Details

Reviewers
mharbison72
Group Reviewers
hg-reviewers
Commits
rHGa83e1496d943: actions: calculate what all parts does the operation touches
Summary

To make upgrade work less in certain situations, we need to teach it to find out
what all parts of repository current operation is touching.

This patch starts doing that. In next patch we will be setting values in
improvement objects. For now, we assume everything touches everything.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Jan 14 2021, 7:54 AM
mharbison72 accepted this revision.Jan 18 2021, 9:19 PM
This revision is now accepted and ready to land.Jan 18 2021, 9:19 PM
baymax updated this revision to Diff 25199.Jan 21 2021, 9:28 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mmercurial/upgrade_utils/actions.py (90 lines)

Diff 25199

mercurial/upgrade_utils/actions.py

postupgrademessage postupgrademessage
Message intended for humans which will be shown post an upgrade Message intended for humans which will be shown post an upgrade
operation when the improvement will be added operation when the improvement will be added
postdowngrademessage postdowngrademessage
Message intended for humans which will be shown post an upgrade Message intended for humans which will be shown post an upgrade
operation in which this improvement was removed operation in which this improvement was removed
touches_filelogs (bool)
Whether this improvement touches filelogs
touches_manifests (bool)
Whether this improvement touches manifests
touches_changelog (bool)
Whether this improvement touches changelog
touches_requirements (bool)
Whether this improvement changes repository requirements
""" """
def __init__(self, name, type, description, upgrademessage): def __init__(self, name, type, description, upgrademessage):
self.name = name self.name = name
self.type = type self.type = type
self.description = description self.description = description
self.upgrademessage = upgrademessage self.upgrademessage = upgrademessage
self.postupgrademessage = None self.postupgrademessage = None
self.postdowngrademessage = None self.postdowngrademessage = None
# By default for now, we assume every improvement touches
# all the things
self.touches_filelogs = True
self.touches_manifests = True
self.touches_changelog = True
self.touches_requirements = True
def __eq__(self, other): def __eq__(self, other):
if not isinstance(other, improvement): if not isinstance(other, improvement):
# This is what python tell use to do # This is what python tell use to do
return NotImplemented return NotImplemented
return self.name == other.name return self.name == other.name
def __ne__(self, other): def __ne__(self, other):
# Message intended for humans which will be shown post an upgrade # Message intended for humans which will be shown post an upgrade
# operation when the improvement will be added # operation when the improvement will be added
postupgrademessage = None postupgrademessage = None
# Message intended for humans which will be shown post an upgrade # Message intended for humans which will be shown post an upgrade
# operation in which this improvement was removed # operation in which this improvement was removed
postdowngrademessage = None postdowngrademessage = None
# By default for now, we assume every improvement touches all the things
touches_filelogs = True
touches_manifests = True
touches_changelog = True
touches_requirements = True
def __init__(self): def __init__(self):
raise NotImplementedError() raise NotImplementedError()
@staticmethod @staticmethod
def fromrepo(repo): def fromrepo(repo):
"""current value of the variant in the repository""" """current value of the variant in the repository"""
raise NotImplementedError() raise NotImplementedError()
# should this operation force re-delta of both parents # should this operation force re-delta of both parents
self.force_re_delta_both_parents = ( self.force_re_delta_both_parents = (
b're-delta-multibase' in self._upgrade_actions_names b're-delta-multibase' in self._upgrade_actions_names
) )
# should this operation create a backup of the store # should this operation create a backup of the store
self.backup_store = backup_store self.backup_store = backup_store
# whether the operation touches different revlogs at all or not
self.touches_filelogs = self._touches_filelogs()
self.touches_manifests = self._touches_manifests()
self.touches_changelog = self._touches_changelog()
# whether the operation touches requirements file or not
self.touches_requirements = self._touches_requirements()
self.touches_store = (
self.touches_filelogs
or self.touches_manifests
or self.touches_changelog
)
# does the operation only touches repository requirement
self.requirements_only = (
self.touches_requirements and not self.touches_store
)
def _touches_filelogs(self):
for a in self.upgrade_actions:
# in optimisations, we re-process the revlogs again
if a.type == OPTIMISATION:
return True
elif a.touches_filelogs:
return True
for a in self.removed_actions:
if a.touches_filelogs:
return True
return False
def _touches_manifests(self):
for a in self.upgrade_actions:
# in optimisations, we re-process the revlogs again
if a.type == OPTIMISATION:
return True
elif a.touches_manifests:
return True
for a in self.removed_actions:
if a.touches_manifests:
return True
return False
def _touches_changelog(self):
for a in self.upgrade_actions:
# in optimisations, we re-process the revlogs again
if a.type == OPTIMISATION:
return True
elif a.touches_changelog:
return True
for a in self.removed_actions:
if a.touches_changelog:
return True
return False
def _touches_requirements(self):
for a in self.upgrade_actions:
# optimisations are used to re-process revlogs and does not result
# in a requirement being added or removed
if a.type == OPTIMISATION:
pass
elif a.touches_requirements:
return True
for a in self.removed_actions:
if a.touches_requirements:
return True
return False
def _write_labeled(self, l, label): def _write_labeled(self, l, label):
""" """
Utility function to aid writing of a list under one label Utility function to aid writing of a list under one label
""" """
first = True first = True
for r in sorted(l): for r in sorted(l):
if not first: if not first:
self.ui.write(b', ') self.ui.write(b', ')