This is an archive of the discontinued Mercurial Phabricator instance.

share: rename share-safe warning config
ClosedPublic

Authored by pulkit on Jan 15 2021, 1:47 AM.

Details

Summary

Config introduced in previous patch was share.source-safe-mismatch. Let's
rename the warn as share.source-safe-mismatch.warn.

While we are here, made sure we have different configs for upgrade and
downgrade.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Jan 15 2021, 1:47 AM
marmoute accepted this revision.Jan 15 2021, 5:29 AM
marmoute added a subscriber: marmoute.

That one looks good. Can we get a patch documenting these option and the share safe behavior above that series ?

marmoute requested changes to this revision.Jan 18 2021, 4:57 AM

Same as before, we will have two different option as one case (probably upgrade) migh be expected within an organization but not the other.

This revision now requires changes to proceed.Jan 18 2021, 4:57 AM
pulkit updated this revision to Diff 25122.Jan 18 2021, 10:41 AM
pulkit updated this revision to Diff 25127.Jan 18 2021, 11:12 AM
pulkit edited the summary of this revision. (Show Details)Jan 18 2021, 11:35 AM
pulkit updated this revision to Diff 25129.
marmoute accepted this revision.Jan 18 2021, 11:49 AM

This looks good, thanks.

Maybe point to the warn config from the doc of the behavior ones ? Or maybe better, sort the section by alphabetical order so that the warn option directly follow the respective behavior one.

mharbison72 accepted this revision.Jan 18 2021, 9:08 PM
This revision is now accepted and ready to land.Jan 18 2021, 9:08 PM
This revision was automatically updated to reflect the committed changes.