This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9817

relnote: remove the reference to `debugstrip`
ClosedPublic

Authored by marmoute on Jan 18 2021, 4:25 AM.

Details

Reviewers
Alphare
martinvonz
Group Reviewers
hg-reviewers
Commits
rHGdd926ce1de28: relnote: remove the reference to `debugstrip`
Summary

The debug namespace is not intended for end user and advertising it is a path
to confusion and trouble. I think we should wait for the admin namespace to
exists and the command to be available as admin--strip before we advertise it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 18 2021, 4:25 AM
Alphare accepted this revision.Feb 8 2021, 5:04 AM
marmoute added subscribers: mharbison72, pulkit, martinvonz.Feb 9 2021, 12:46 PM

Apparently this did not make it to core before the release… We need to get the changelog fixed.

cc @martinvonz @pulkit @mharbison72

martinvonz added a subscriber: valentin.gatienbaron.Feb 9 2021, 12:54 PM
In D9817#151003, @marmoute wrote:

Apparently this did not make it to core before the release… We need to get the changelog fixed.
cc @martinvonz @pulkit @mharbison72

Also cc @valentin.gatienbaron who added the section to the release notes.

I haven't been involved in the discussion about namespaces and wasn't even aware that this would become hg admin--strip, but that seems fine to me. Thoughts from someone who has followed the discussion more closely?

valentin.gatienbaron added a comment.Feb 9 2021, 1:03 PM

No particular opinion, I have not really followed this namespace discussion. I would have thought there's a number of other debugcommands that are admin commands, like debugrebuilddirstate, so one more wouldn't make a difference, but maybe that's incorrect.

marmoute added a comment.Feb 9 2021, 1:20 PM
In D9817#151007, @valentin.gatienbaron wrote:

No particular opinion, I have not really followed this namespace discussion. I would have thought there's a number of other debugcommands that are admin commands, like debugrebuilddirstate, so one more wouldn't make a difference, but maybe that's incorrect.

I don't think the other "debug command that are used as admin command" have beend publicly advertised in the Mercurial changelog so far. And this is what I am trying to avoid, having users expecting the debug namespace to be safe.

martinvonz accepted this revision.Feb 9 2021, 1:27 PM

Queued

This revision is now accepted and ready to land.Feb 9 2021, 1:27 PM
marmoute added a commit: rHGdd926ce1de28: relnote: remove the reference to `debugstrip`.Feb 9 2021, 1:28 PM
Closed by commit rHGdd926ce1de28: relnote: remove the reference to `debugstrip` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrelnotes/5.7 (3 lines)

Diff 25511

relnotes/5.7

* There is a new set of config options for the template used for the * There is a new set of config options for the template used for the
one-line commit summary displayed by various commands, such as `hg one-line commit summary displayed by various commands, such as `hg
rebase`. The main one is `command-templates.oneline-summary`. That rebase`. The main one is `command-templates.oneline-summary`. That
can be overridden per command with can be overridden per command with
`command-templates.oneline-summary.<command>`, where `<command>` `command-templates.oneline-summary.<command>`, where `<command>`
can be e.g. `rebase`. As part of this effort, the default format can be e.g. `rebase`. As part of this effort, the default format
from `hg rebase` was reorganized a bit. from `hg rebase` was reorganized a bit.
* `hg strip`, from the strip extension, is now a core command, `hg
debugstrip`. The extension remains for compatibility.
* `hg diff` and `hg extdiff` now support `--from <rev>` and `--to <rev>` * `hg diff` and `hg extdiff` now support `--from <rev>` and `--to <rev>`
arguments as clearer alternatives to `-r <revs>`. `-r <revs>` has been arguments as clearer alternatives to `-r <revs>`. `-r <revs>` has been
deprecated. deprecated.
* The memory footprint per changeset during pull/unbundle * The memory footprint per changeset during pull/unbundle
operations has been further reduced. operations has been further reduced.
* There is a new internal merge tool called `internal:mergediff` (can * There is a new internal merge tool called `internal:mergediff` (can