This is an archive of the discontinued Mercurial Phabricator instance.

mercurial/pure/parsers.py
48–49	Correction: since `index_format` starts with `>`, it opts in both to big-endian and to "stardard sizes" so `index_size` is in fact platform-independent. See docs in https://docs.python.org/3/library/struct.html#format-characters Maybe `>` should be added to the format string for `big_int_size` and `int_size` as well, just to be safe.

Alphare added inline comments.Mar 4 2021, 10:02 AM

mercurial/pure/parsers.py
48–49	Thanks for the catch, I'll add `>` to the other format strings

Alphare edited the summary of this revision. (Show Details)Mar 4 2021, 10:10 AM

Alphare added a child revision: D10107: requirements: also add a dotencode constant.

Alphare updated this revision to Diff 26080.

pulkit accepted this revision.Mar 5 2021, 3:37 AM

Alphare added a commit: rHGe83327af26f1: pure-parsers: document index class constants.Mar 5 2021, 4:34 AM

Closed by commit rHGe83327af26f1: pure-parsers: document index class constants (authored by Alphare). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/pure/parsers.py (9 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	26040		Mar 4 2021, 3:31 AM	★	★
Diff 2	26080		Mar 4 2021, 10:10 AM	★	★
Diff 3	26101	rHGe83327af26f158c21ceac95324dd4cb0e0bdfa96	Mar 2 2021, 12:51 PM	★	★

Status	Author	Revision
Closed	Alphare	D10216 configitems: add TODOs blocking the move out of experimental for revlogv2
Closed	Alphare	D10032 sidedata-exchange: rewrite sidedata on-the-fly whenever possible
Closed	Alphare	D10031 revlog-index: add `replace_sidedata_info` method
Closed	Alphare	D10030 revlogv2: temporarily forbid inline revlogs
Closed	Alphare	D10029 changegroupv4: add sidedata helpers
Closed	Alphare	D10151 revlog: add attribute on revlogs that specifies its kind
Closed	Alphare	D10028 sidedata-exchange: add `wanted_sidedata` and `sidedata_computers` to repos
Closed	Alphare	D10027 delta: add sidedata field to revision delta
Closed	Alphare	D10026 changegroup: add v4 changegroup for revlog v2 exchange
Closed	Alphare	D10025 revlogv2: don't assume that the sidedata of the last rev is right after data
Closed	Alphare	D9993 sidedata: move to new sidedata storage in revlogv2
Closed	Alphare	D9846 cext: add support for revlogv2
Closed	Alphare	D9845 bitmanipulation: add utils to read/write bigendian 64bit integers
Closed	Alphare	D10113 format: remove sidedata format variant
Closed	Alphare	D9844 revlogv2: allow upgrading to v2
Closed	Alphare	D9843 revlog: introduce v2 format
Closed	Alphare	D10109 requirements: also add a fncache constant
Closed	Alphare	D10108 requirements: also add a store constant
Closed	Alphare	D10107 requirements: also add a dotencode constant
Closed	Alphare	D10106 requirements: also add a generaldelta constant
Closed	Alphare	D10105 requirements: add constant for revlog v1 requirement
Closed	Alphare	D10024 error: add `hint` attribute to `SidedataHashError`
Closed	Alphare	D10023 changegroup: use the local variable instead of reaching through self
Closed	Alphare	D10104 pure-parsers: document index class constants

Diff 26101

mercurial/pure/parsers.py

	return int(q & 0xFFFF)			return int(q & 0xFFFF)


	def offset_type(offset, type):			def offset_type(offset, type):
	return int(int(offset) << 16 \| type)			return int(int(offset) << 16 \| type)


	class BaseIndexObject(object):			class BaseIndexObject(object):
				# Format of an index entry according to Python's `struct` language
	index_format = b">Qiiiiii20s12x"			index_format = b">Qiiiiii20s12x"
	big_int_size = struct.calcsize(b'Q')			# Size of a C unsigned long long int, platform independent
	int_size = struct.calcsize(b'i')			big_int_size = struct.calcsize(b'>Q')
				# Size of a C long int, platform independent
				SimonSapinUnsubmitted Not Done This description isn’t factually wrong, but wouldn’t it be a serious bug if the on-disk format ends up varying across different platforms? SimonSapin: This description isn’t factually wrong, but wouldn’t it be a serious bug if the on-disk format…
				SimonSapinUnsubmitted Not Done Correction: since `index_format` starts with `>`, it opts in both to big-endian and to "stardard sizes" so `index_size` is in fact platform-independent. See docs in https://docs.python.org/3/library/struct.html#format-characters Maybe `>` should be added to the format string for `big_int_size` and `int_size` as well, just to be safe. SimonSapin: Correction: since `index_format` starts with `>`, it opts in both to big-endian and to…
				AlphareAuthorUnsubmitted Done Thanks for the catch, I'll add `>` to the other format strings Alphare: Thanks for the catch, I'll add `>` to the other format strings
				int_size = struct.calcsize(b'>i')
				# Size of the entire index format
	index_size = struct.calcsize(index_format)			index_size = struct.calcsize(index_format)
				# An empty index entry, used as a default value to be overridden, or nullrev
	null_item = (0, 0, 0, -1, -1, -1, -1, nullid)			null_item = (0, 0, 0, -1, -1, -1, -1, nullid)

	@property			@property
	def nodemap(self):			def nodemap(self):
	msg = b"index.nodemap is deprecated, use index.[has_node\|rev\|get_rev]"			msg = b"index.nodemap is deprecated, use index.[has_node\|rev\|get_rev]"
	util.nouideprecwarn(msg, b'5.3', stacklevel=2)			util.nouideprecwarn(msg, b'5.3', stacklevel=2)
	return self._nodemap			return self._nodemap

This is an archive of the discontinued Mercurial Phabricator instance.

pure-parsers: document index class constantsClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26101

mercurial/pure/parsers.py

pure-parsers: document index class constants
ClosedPublic

Revision Contents
Changeset List