( )⚙ D10210 crecord: null out the curses attribute with `None` on failure to import

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10210

crecord: null out the curses attribute with `None` on failure to import
ClosedPublic

Authored by mharbison72 on Mar 13 2021, 2:33 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG693991ccfc49: crecord: null out the curses attribute with `None` on failure to import
Summary

Pytype got really confused that this could be Union[module, bool], and spewed
about tons of attributes that are not available on bool.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/crecord.py (2 lines)

Diff 26324

mercurial/crecord.py

) )
try: try:
import curses import curses
import curses.ascii import curses.ascii
curses.error curses.error
except (ImportError, AttributeError): except (ImportError, AttributeError):
curses = False curses = None
class fallbackerror(error.Abort): class fallbackerror(error.Abort):
"""Error that indicates the client should try to fallback to text mode.""" """Error that indicates the client should try to fallback to text mode."""
# Inherits from error.Abort so that existing behavior is preserved if the # Inherits from error.Abort so that existing behavior is preserved if the
# calling code does not know how to fallback. # calling code does not know how to fallback.