( )⚙ D10785 revlog: use dedicated code for reading sidedata

This is an archive of the discontinued Mercurial Phabricator instance.

revlog: use dedicated code for reading sidedata
ClosedPublic

Authored by marmoute on May 28 2021, 6:56 PM.

Details

Summary

We are about to introduce a new, dedicated, file to store sidedata. Before doing so, we make sidedata reading go through different code as reading data chunk. This will simplify some of the complexity of the next changesets.

The reading is very simple right now and will need some improvement later to
reuse some of the caching strategy we use for the data file.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 28 2021, 6:56 PM
Alphare accepted this revision as: Alphare.May 31 2021, 6:23 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
mercurial/revlog.py
2081

Since this is an error case that isn't supposed to happen often, maybe we could factor this in a function?

baymax updated this revision to Diff 28298.May 31 2021, 6:37 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added inline comments.May 31 2021, 9:25 AM
mercurial/revlog.py
2081

I am not sure we will gain much as most of the block size is about passing parameter to the formatting.

baymax updated this revision to Diff 28395.Jun 1 2021, 11:10 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28444.Jun 4 2021, 9:54 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.