Page MenuHomePhabricator

cmdutil: pass metadata from amend() to cleanupnodes
ClosedPublic

Authored by pulkit on Oct 15 2017, 10:28 AM.

Details

Summary

commit --amend and amend command in core and extensions rely on
cmdutil.amend() for amending a commit. So the logic to add a note to amend must
reside here. This patch assumes that note will be passed in opts dictionary to
the function and it will be passed to cleanupnodes and then createmarkers to
store the note in the obsmarker metadata.

After this patch, note can be stored on an amend changeset by passing notes as a
part of opts to cmdutil.amend().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Oct 15 2017, 10:28 AM
dlax accepted this revision.Oct 16 2017, 4:27 AM
durin42 accepted this revision.Oct 16 2017, 9:36 PM
This revision is now accepted and ready to land.Oct 16 2017, 9:36 PM
This revision was automatically updated to reflect the committed changes.