( )⚙ D10967 dirstate: use a `added` parameter to _addpath

This is an archive of the discontinued Mercurial Phabricator instance.

dirstate: use a `added` parameter to _addpath
ClosedPublic

Authored by marmoute on Jul 4 2021, 5:51 PM.

Details

Summary

My next target are the explicit state byte, so let start with abstracting
their initial storage.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 4 2021, 5:51 PM
SimonSapin accepted this revision.Jul 5 2021, 12:52 AM
SimonSapin added a subscriber: SimonSapin.
SimonSapin added inline comments.
rust/hg-cpython/src/dirstate/dirstate_map.rs
122–123

I’m not a fan of this, but I see that it changes soon anyway in other patches

pulkit accepted this revision.Jul 6 2021, 12:43 PM
This revision is now accepted and ready to land.Jul 6 2021, 12:43 PM
baymax updated this revision to Diff 28869.Jul 6 2021, 2:09 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

This revision was automatically updated to reflect the committed changes.