( )⚙ D10969 dirstate: use a `merged` parameter to _addpath

This is an archive of the discontinued Mercurial Phabricator instance.

dirstate: use a `merged` parameter to _addpath
ClosedPublic

Authored by marmoute on Jul 4 2021, 5:51 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 4 2021, 5:51 PM
SimonSapin accepted this revision.Jul 5 2021, 1:01 AM
SimonSapin added a subscriber: SimonSapin.
SimonSapin added inline comments.
rust/hg-core/src/dirstate_tree/dispatch.rs
292–295

This can be a follow-up and you already have a comment elsewhere to that effect, but this is increasingly too many order-sensitive boolean parameters

marmoute added inline comments.Jul 5 2021, 4:42 AM
rust/hg-core/src/dirstate_tree/dispatch.rs
292–295

Once the "migration" is done, we should probably burn the whole dirstatemap.addfile API to the ground a rebuild something cleaner.

pulkit added a subscriber: pulkit.Jul 6 2021, 12:44 PM
pulkit added inline comments.
rust/hg-core/src/dirstate_tree/dispatch.rs
292–295

I agree with Simon here but yes a better API can wait for current refactoring to be finished.

pulkit accepted this revision.Jul 6 2021, 12:45 PM
This revision is now accepted and ready to land.Jul 6 2021, 12:45 PM
marmoute added inline comments.Jul 6 2021, 12:50 PM
rust/hg-core/src/dirstate_tree/dispatch.rs
292–295

I think everybody agree with Simon :-)

baymax updated this revision to Diff 28871.Jul 6 2021, 2:09 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

This revision was automatically updated to reflect the committed changes.