( )⚙ D11571 dirstatemap: add a common `_refresh_entry` method for dirstatemap

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11571

dirstatemap: add a common `_refresh_entry` method for dirstatemap
ClosedPublic

Authored by marmoute on Oct 2 2021, 11:05 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGa1a6569b9283: dirstatemap: add a common `_refresh_entry` method for dirstatemap
Summary

This method is called once a DirstateItem have been modified to apply the
change on the dirstatemap if necessary.

Each variant have a different implementation (which is … the point).

We use addfile for the rustmap and not set_dirstate_item because we need to
keep the internal counter up to date and set_dirstate_item does not do it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstatemap.py (13 lines)

Diff 30628

mercurial/dirstatemap.py

def _dirs_decr(self, filename, old_entry=None, remove_variant=False): def _dirs_decr(self, filename, old_entry=None, remove_variant=False):
"""decremente the dirstate counter if applicable """decremente the dirstate counter if applicable
This might be a no-op for some subclass who deal with directory This might be a no-op for some subclass who deal with directory
tracking in a different way. tracking in a different way.
""" """
def _refresh_entry(self, f, entry):
"""record updated state of an entry"""
class dirstatemap(_dirstatemapcommon): class dirstatemap(_dirstatemapcommon):
"""Map encapsulating the dirstate's contents. """Map encapsulating the dirstate's contents.
The dirstate contains the following state: The dirstate contains the following state:
- `identity` is the identity of the dirstate file, which can be used to - `identity` is the identity of the dirstate file, which can be used to
detect when changes have occurred to the dirstate file. detect when changes have occurred to the dirstate file.
return pathutil.dirs(self._map, only_tracked=True) return pathutil.dirs(self._map, only_tracked=True)
@propertycache @propertycache
def _alldirs(self): def _alldirs(self):
return pathutil.dirs(self._map) return pathutil.dirs(self._map)
### code related to manipulation of entries and copy-sources ### code related to manipulation of entries and copy-sources
def _refresh_entry(self, f, entry):
if not entry.any_tracked:
self._map.pop(f, None)
def set_possibly_dirty(self, filename): def set_possibly_dirty(self, filename):
"""record that the current state of the file on disk is unknown""" """record that the current state of the file on disk is unknown"""
self[filename].set_possibly_dirty() self[filename].set_possibly_dirty()
def set_clean(self, filename, mode, size, mtime): def set_clean(self, filename, mode, size, mtime):
"""mark a file as back to a clean state""" """mark a file as back to a clean state"""
entry = self[filename] entry = self[filename]
mtime = mtime & rangemask mtime = mtime & rangemask
f = {} f = {}
normcase = util.normcase normcase = util.normcase
for name in self._map.tracked_dirs(): for name in self._map.tracked_dirs():
f[normcase(name)] = name f[normcase(name)] = name
return f return f
### code related to manipulation of entries and copy-sources ### code related to manipulation of entries and copy-sources
def _refresh_entry(self, f, entry):
if not entry.any_tracked:
self._map.drop_item_and_copy_source(f)
else:
self._map.addfile(f, entry)
def set_possibly_dirty(self, filename): def set_possibly_dirty(self, filename):
"""record that the current state of the file on disk is unknown""" """record that the current state of the file on disk is unknown"""
entry = self[filename] entry = self[filename]
entry.set_possibly_dirty() entry.set_possibly_dirty()
self._map.set_dirstate_item(filename, entry) self._map.set_dirstate_item(filename, entry)
def set_clean(self, filename, mode, size, mtime): def set_clean(self, filename, mode, size, mtime):
"""mark a file as back to a clean state""" """mark a file as back to a clean state"""