( )⚙ D11582 dirstatemap: drop legacy method on the dirstatemap wrapper

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11582

dirstatemap: drop legacy method on the dirstatemap wrapper
ClosedPublic

Authored by marmoute on Oct 2 2021, 11:06 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG25836b0029f5: dirstatemap: drop legacy method on the dirstatemap wrapper
Summary

They are no longer in use now that the Rust wrapper version of the Dirstatemap
are back in line with the Python one.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstatemap.py (39 lines)

Diff 30639

mercurial/dirstatemap.py

self._map.addfile(f, entry) self._map.addfile(f, entry)
def _drop_entry(self, f): def _drop_entry(self, f):
self._map.drop_item_and_copy_source(f) self._map.drop_item_and_copy_source(f)
def __setitem__(self, key, value): def __setitem__(self, key, value):
assert isinstance(value, DirstateItem) assert isinstance(value, DirstateItem)
self._map.set_dirstate_item(key, value) self._map.set_dirstate_item(key, value)
### Legacy method we need to get rid of
def addfile(
self,
f,
mode=0,
size=None,
mtime=None,
added=False,
merged=False,
from_p2=False,
possibly_dirty=False,
):
if added:
assert not possibly_dirty
assert not from_p2
item = DirstateItem.new_added()
elif merged:
assert not possibly_dirty
assert not from_p2
item = DirstateItem.new_merged()
elif from_p2:
assert not possibly_dirty
item = DirstateItem.new_from_p2()
elif possibly_dirty:
item = DirstateItem.new_possibly_dirty()
else:
assert size is not None
assert mtime is not None
size = size & rangemask
mtime = mtime & rangemask
item = DirstateItem.new_normal(mode, size, mtime)
self._map.addfile(f, item)
if added:
self.copymap.pop(f, None)
def removefile(self, *args, **kwargs):
return self._map.removefile(*args, **kwargs)