( )⚙ D11606 dirstate-item: replace a call to new_possibly_dirty

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11606

dirstate-item: replace a call to new_possibly_dirty
ClosedPublic

Authored by marmoute on Oct 3 2021, 6:53 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG79ebbe19d9e3: dirstate-item: replace a call to new_normal
Summary

The constructor is on its way out, so we inline a relevant call before
dropping it.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Oct 3 2021, 6:53 AM
Alphare added a subscriber: Alphare.Oct 3 2021, 5:20 PM

The description talks about new_possibly_dirty, but the change is about new_normal. I'll also amend it on-the-fly

marmoute added a commit: rHG79ebbe19d9e3: dirstate-item: replace a call to new_normal.Oct 3 2021, 5:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG79ebbe19d9e3: dirstate-item: replace a call to new_normal (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/pure/parsers.py (9 lines)

Diff 30611

mercurial/pure/parsers.py

p2_info = False p2_info = False
return cls(p1_tracked=p1_tracked, p2_info=p2_info) return cls(p1_tracked=p1_tracked, p2_info=p2_info)
elif state == b'n': elif state == b'n':
if size == FROM_P2: if size == FROM_P2:
return cls(wc_tracked=True, p2_info=True) return cls(wc_tracked=True, p2_info=True)
elif size == NONNORMAL: elif size == NONNORMAL:
return cls(wc_tracked=True, p1_tracked=True) return cls(wc_tracked=True, p1_tracked=True)
elif mtime == AMBIGUOUS_TIME: elif mtime == AMBIGUOUS_TIME:
instance = cls.new_normal(mode, size, 42) return cls(
instance._mtime = None wc_tracked=True,
return instance p1_tracked=True,
has_meaningful_mtime=False,
parentfiledata=(mode, size, 42),
)
else: else:
return cls.new_normal(mode, size, mtime) return cls.new_normal(mode, size, mtime)
else: else:
raise RuntimeError(b'unknown state: %s' % state) raise RuntimeError(b'unknown state: %s' % state)
def set_possibly_dirty(self): def set_possibly_dirty(self):
"""Mark a file as "possibly dirty" """Mark a file as "possibly dirty"