Page MenuHomePhabricator

dirstate-v2: reorder flag to group related one together
ClosedPublic

Authored by marmoute on Oct 19 2021, 7:01 PM.

Details

Summary

Since the format is not frozen yet, it seems like the right moment to do it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 19 2021, 7:01 PM
Alphare requested changes to this revision.Oct 20 2021, 4:56 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
mercurial/cext/util.h
45

Note that this is "has mode and size" in the documentation, the Rust as well as the Python implementation. It's probably worth renaming here

This revision now requires changes to proceed.Oct 20 2021, 4:56 AM
marmoute updated this revision to Diff 30936.Oct 20 2021, 5:13 AM
marmoute added inline comments.Oct 20 2021, 5:13 AM
mercurial/cext/util.h
45

I would rather do a follow up than mixing a rename in the reorder.

Alphare accepted this revision.Oct 20 2021, 5:26 AM
Alphare added inline comments.
mercurial/cext/util.h
45

Sure

This revision is now accepted and ready to land.Oct 20 2021, 5:26 AM
This revision was automatically updated to reflect the committed changes.