( )⚙ D2190 narrowspec: document constraints when validating patterns

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2190

narrowspec: document constraints when validating patterns
ClosedPublic

Authored by durin42 on Feb 12 2018, 3:03 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG9c55bbc29dcf: narrowspec: document constraints when validating patterns
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Feb 12 2018, 3:03 PM
indygreg accepted this revision.Feb 12 2018, 5:55 PM
This revision is now accepted and ready to land.Feb 12 2018, 5:55 PM
Closed by commit rHG9c55bbc29dcf: narrowspec: document constraints when validating patterns (authored by durin42). · Explain WhyFeb 12 2018, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowspec.py (6 lines)

Diff 5506

hgext/narrow/narrowspec.py

def _numlines(s): def _numlines(s):
"""Returns the number of lines in s, including ending empty lines.""" """Returns the number of lines in s, including ending empty lines."""
# We use splitlines because it is Unicode-friendly and thus Python 3 # We use splitlines because it is Unicode-friendly and thus Python 3
# compatible. However, it does not count empty lines at the end, so trick # compatible. However, it does not count empty lines at the end, so trick
# it by adding a character at the end. # it by adding a character at the end.
return len((s + 'x').splitlines()) return len((s + 'x').splitlines())
def _validatepattern(pat): def _validatepattern(pat):
"""Validates the pattern and aborts if it is invalid.""" """Validates the pattern and aborts if it is invalid.
Patterns are stored in the narrowspec as newline-separated
POSIX-style bytestring paths. There's no escaping.
"""
# We use newlines as separators in the narrowspec file, so don't allow them # We use newlines as separators in the narrowspec file, so don't allow them
# in patterns. # in patterns.
if _numlines(pat) > 1: if _numlines(pat) > 1:
raise error.Abort('newlines are not allowed in narrowspec paths') raise error.Abort('newlines are not allowed in narrowspec paths')
components = pat.split('/') components = pat.split('/')
if '.' in components or '..' in components: if '.' in components or '..' in components: