( )⚙ D6295 phabricator: use templatefilters.json in writediffproperties

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6295

phabricator: use templatefilters.json in writediffproperties
ClosedPublic

Authored by Kwan on Apr 22 2019, 11:45 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG289d82a070e9: phabricator: use templatefilters.json in writediffproperties
Summary

Instead of json.dumps, since it makes the code simpler and more readable.
This would have been the better option for 8fd19a7b4ed6 but I wasn't aware of
it at the time.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Kwan created this revision.Apr 22 2019, 11:45 AM
pulkit accepted this revision.Apr 22 2019, 12:02 PM
Kwan retitled this revision from phabricator: use templatefilters.json instead of json.dumps in writediffproperties to phabricator: use templatefilters.json in writediffproperties.Apr 22 2019, 1:31 PM
Kwan edited the summary of this revision. (Show Details)
Closed by commit rHG289d82a070e9: phabricator: use templatefilters.json in writediffproperties (authored by Kwan). · Explain WhyApr 22 2019, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (22 lines)

Diff 14881

hgext/phabricator.py

parser, parser,
patch, patch,
phases, phases,
pycompat, pycompat,
registrar, registrar,
scmutil, scmutil,
smartset, smartset,
tags, tags,
templatefilters,
templateutil, templateutil,
url as urlmod, url as urlmod,
util, util,
) )
from mercurial.utils import ( from mercurial.utils import (
procutil, procutil,
stringutil, stringutil,
) )
raise error.Abort(_(b'cannot create diff for %s') % ctx) raise error.Abort(_(b'cannot create diff for %s') % ctx)
return diff return diff
def writediffproperties(ctx, diff): def writediffproperties(ctx, diff):
"""write metadata to diff so patches could be applied losslessly""" """write metadata to diff so patches could be applied losslessly"""
params = { params = {
b'diff_id': diff[b'id'], b'diff_id': diff[b'id'],
b'name': b'hg:meta', b'name': b'hg:meta',
b'data': json.dumps({ b'data': templatefilters.json({
u'user': encoding.unifromlocal(ctx.user()), b'user': ctx.user(),
u'date': u'{:.0f} {}'.format(*ctx.date()), b'date': b'%d %d' % ctx.date(),
u'node': encoding.unifromlocal(ctx.hex()), b'node': ctx.hex(),
u'parent': encoding.unifromlocal(ctx.p1().hex()), b'parent': ctx.p1().hex(),
}), }),
} }
callconduit(ctx.repo(), b'differential.setdiffproperty', params) callconduit(ctx.repo(), b'differential.setdiffproperty', params)
params = { params = {
b'diff_id': diff[b'id'], b'diff_id': diff[b'id'],
b'name': b'local:commits', b'name': b'local:commits',
b'data': json.dumps({ b'data': templatefilters.json({
encoding.unifromlocal(ctx.hex()): { ctx.hex(): {
u'author': encoding.unifromlocal(stringutil.person(ctx.user())), b'author': stringutil.person(ctx.user()),
u'authorEmail': encoding.unifromlocal( b'authorEmail': stringutil.email(ctx.user()),
stringutil.email(ctx.user())), b'time': b'%d' % ctx.date()[0],
u'time': u'{:.0f}'.format(ctx.date()[0]),
}, },
}), }),
} }
callconduit(ctx.repo(), b'differential.setdiffproperty', params) callconduit(ctx.repo(), b'differential.setdiffproperty', params)
def createdifferentialrevision(ctx, revid=None, parentrevid=None, oldnode=None, def createdifferentialrevision(ctx, revid=None, parentrevid=None, oldnode=None,
olddiff=None, actions=None): olddiff=None, actions=None):
"""create or update a Differential Revision """create or update a Differential Revision