This is an archive of the discontinued Mercurial Phabricator instance.

hgext/phabricator.py
403	I left it out since the "hg:meta" code only writes p1 ( `b'parent': ctx.p1().hex(),`) and `getdiffmeta` doesn't read p2 from either "hg:meta" or "local:commits": if len(commit.get(b'parents', ())) >= 1: meta[b'parent'] = commit[b'parents'][0] Adding it to all three could be a followup.

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			hgext/phabricator.py (2 lines)

Commit	Parents	Author	Summary	Date
e8bdb45aff14	c114a429f869	Ian Moody		Apr 20 2019, 11:11 AM

Status	Author	Revision
Closed	Kwan	D6347 phabricator: add custom vcr matcher to match request bodies
Closed	Kwan	D6302 phabricator: include branch in the phabread output
Closed	Kwan	D6301 phabricator: fallback to reading metadata from diff for phabread
Closed	Kwan	D6300 phabricator: read more metadata from local:commits
Closed	Kwan	D6299 phabricator: don't assume the existence of properties of local:commits
Closed	Kwan	D6298 phabricator: include commit (node) and parent in the local:commits metadata
Closed	Kwan	D6297 phabricator: include branch in the diffproperty metadata
Closed	Kwan	D6296 phabricator: set local:commits time metadata as an int, not a string
Closed	Kwan	D6295 phabricator: use templatefilters.json in writediffproperties

	params = {			params = {
	b'diff_id': diff[b'id'],			b'diff_id': diff[b'id'],
	b'name': b'local:commits',			b'name': b'local:commits',
	b'data': templatefilters.json({			b'data': templatefilters.json({
	ctx.hex(): {			ctx.hex(): {
	b'author': stringutil.person(ctx.user()),			b'author': stringutil.person(ctx.user()),
	b'authorEmail': stringutil.email(ctx.user()),			b'authorEmail': stringutil.email(ctx.user()),
	b'time': int(ctx.date()[0]),			b'time': int(ctx.date()[0]),
				b'commit': ctx.hex(),
				b'parents': [ctx.p1().hex()],
				indygregUnsubmitted Not Done What about p2? indygreg: What about p2?
				KwanAuthorUnsubmitted Not Done I left it out since the "hg:meta" code only writes p1 ( `b'parent': ctx.p1().hex(),`) and `getdiffmeta` doesn't read p2 from either "hg:meta" or "local:commits": if len(commit.get(b'parents', ())) >= 1: meta[b'parent'] = commit[b'parents'][0] Adding it to all three could be a followup. Kwan: I left it out since the "hg:meta" code only writes p1 (` b'parent': ctx.p1().hex(),`) and…
	b'branch': ctx.branch(),			b'branch': ctx.branch(),
	},			},
	}),			}),
	}			}
	callconduit(ctx.repo(), b'differential.setdiffproperty', params)			callconduit(ctx.repo(), b'differential.setdiffproperty', params)

	def createdifferentialrevision(ctx, revid=None, parentrevid=None, oldnode=None,			def createdifferentialrevision(ctx, revid=None, parentrevid=None, oldnode=None,
	olddiff=None, actions=None):			olddiff=None, actions=None):