Page MenuHomePhabricator

phabricator: include commit (node) and parent in the local:commits metadata
ClosedPublic

Authored by Kwan on Apr 22 2019, 11:52 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Apr 22 2019, 11:52 AM
indygreg added inline comments.
hgext/phabricator.py
403

What about p2?

Kwan added inline comments.Apr 25 2019, 12:54 PM
hgext/phabricator.py
403

I left it out since the "hg:meta" code only writes p1 ( b'parent': ctx.p1().hex(),) and getdiffmeta doesn't read p2 from either "hg:meta" or "local:commits":

if len(commit.get(b'parents', ())) >= 1:
    meta[b'parent'] = commit[b'parents'][0]

Adding it to all three could be a followup.

This revision was automatically updated to reflect the committed changes.