This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: don't assume the existence of properties of local:commits
ClosedPublic

Authored by Kwan on Apr 22 2019, 11:52 AM.

Details

Summary

Not all the properties are guaranteed to be there, so if we don't check first
we could die with a KeyError.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Apr 22 2019, 11:52 AM
indygreg accepted this revision.Apr 24 2019, 10:13 PM
This revision is now accepted and ready to land.Apr 24 2019, 10:13 PM
pulkit accepted this revision.Apr 25 2019, 1:38 PM
This revision was automatically updated to reflect the committed changes.