Until now, shelve was bootstrapped as an extension. This patch adds
shelve on core.
Details
- Reviewers
pulkit - Group Reviewers
hg-reviewers - Commits
- rHG3de4f17f4824: shelve: move shelve extension to core
rHG46087aeb8ae2: shelve: move shelve extension to core
Diff Detail
- Repository
- rHG Mercurial
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
You should probably run hg mv -A hgext/shelve.py mercurial/shelve.py and amend and re-send to preserve history.
mercurial/shelve.py | ||
---|---|---|
652 | We don't import things from hgext in mercurial. I am not sure why. I think it will be fine to duplicate clearstatus() from rebase to shelve.py for the movement and add a comment that it's copied. |
mercurial/shelve.py | ||
---|---|---|
652 | Done. Now, shelve will no longer be dependent on rebase. |
Thanks a lot for working on this. This needs to be rebased on tip of default branch. Also, can you add an entry about shelve extension being moved to core in relnotes/next file.
mercurial/shelve.py | ||
---|---|---|
296–304 | Doing that right away! |
Need to update extensions._builtin so the shelve "extension" is silently
ignored.
Please send a follow up.
mercurial/commands.py | ||
---|---|---|
6190 | I just noticed that the function _dounshelve() still has _ prefix. We generally have that to mark if functions are local to that file or class. So can you send a followup and rename that to dounshelve? |
mercurial/commands.py | ||
---|---|---|
6190 | Doing that right away! |
I just noticed that the function _dounshelve() still has _ prefix. We generally have that to mark if functions are local to that file or class. So can you send a followup and rename that to dounshelve?