This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6822

flagprocessors: move _flagserrorclass attribute on revlog & co
ClosedPublic

Authored by marmoute on Sep 7 2019, 5:29 AM.

Details

Reviewers
yuja
durin42
indygreg
Group Reviewers
hg-reviewers
Commits
rHG3674797ae8b9: flagprocessors: move _flagserrorclass attribute on revlog & co
Summary

This is a small duplication, and the last bit we need to get rid of the mixin.

Honestly, I am not fan of that class attribute and it mostly exist to accomodate
The simple-storage whose usage of flag processors is dumbious and that is
currently dead code anyway. However I don't want to be pulled into futher
unrelated cleaning so it is a small price to pay.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

marmoute created this revision.Sep 7 2019, 5:29 AM
durin42 accepted this revision.Sep 9 2019, 1:57 PM
This revision is now accepted and ready to land.Sep 9 2019, 1:57 PM
marmoute updated this revision to Diff 16488.Sep 9 2019, 5:24 PM
marmoute updated this revision to Diff 16501.Sep 9 2019, 7:09 PM

Revision Contents
Changeset List

Diff 16488

hgext/remotefilelog/remotefilelog.py

def __get__(self, node): def __get__(self, node):
if node not in self: if node not in self:
raise KeyError(node) raise KeyError(node)
return node return node
class remotefilelog(flagutil.flagprocessorsmixin): class remotefilelog(flagutil.flagprocessorsmixin):
_generaldelta = True _generaldelta = True
_flagserrorclass = error.RevlogError
def __init__(self, opener, path, repo): def __init__(self, opener, path, repo):
self.opener = opener self.opener = opener
self.filename = path self.filename = path
self.repo = repo self.repo = repo
self.nodemap = remotefilelognodemap(self.filename, repo.contentstore) self.nodemap = remotefilelognodemap(self.filename, repo.contentstore)
self.version = 1 self.version = 1

mercurial/revlog.py

index will be mmapped rather than read if it is larger than the index will be mmapped rather than read if it is larger than the
configured threshold. configured threshold.
If censorable is True, the revlog can have censored revisions. If censorable is True, the revlog can have censored revisions.
If `upperboundcomp` is not None, this is the expected maximal gain from If `upperboundcomp` is not None, this is the expected maximal gain from
compression for the data content. compression for the data content.
""" """
_flagserrorclass = error.RevlogError
def __init__(self, opener, indexfile, datafile=None, checkambig=False, def __init__(self, opener, indexfile, datafile=None, checkambig=False,
mmaplargeindex=False, censorable=False, mmaplargeindex=False, censorable=False,
upperboundcomp=None): upperboundcomp=None):
""" """
create a revlog object create a revlog object
opener is a function that abstracts the file opening operation opener is a function that abstracts the file opening operation
and can be used to implement COW semantics or the like. and can be used to implement COW semantics or the like.

mercurial/revlogutils/flagutil.py

class flagprocessorsmixin(object): class flagprocessorsmixin(object):
"""basic mixin to support revlog flag processing """basic mixin to support revlog flag processing
Make sure the `_flagprocessors` attribute is set at ``__init__`` time. Make sure the `_flagprocessors` attribute is set at ``__init__`` time.
See the documentation of the ``_processflags`` method for details. See the documentation of the ``_processflags`` method for details.
""" """
_flagserrorclass = error.RevlogError
def processflagswrite(revlog, text, flags, sidedata): def processflagswrite(revlog, text, flags, sidedata):
"""Inspect revision data flags and applies write transformations defined """Inspect revision data flags and applies write transformations defined
by registered flag processors. by registered flag processors.
``text`` - the revision data to process ``text`` - the revision data to process
``flags`` - the revision flags ``flags`` - the revision flags
This method processes the flags in the order (or reverse order if This method processes the flags in the order (or reverse order if