This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7262

templateutil: fix a missing ABCMeta assignment
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:55 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG3e57809d3251: templateutil: fix a missing ABCMeta assignment
Summary

Caught by pytype.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 6 2019, 5:55 PM
indygreg accepted this revision.Nov 7 2019, 3:04 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:04 AM
dlax added a subscriber: dlax.Nov 7 2019, 3:21 AM
dlax added inline comments.
mercurial/templateutil.py
114

This is ignored on Python 3 (meaning it's possible to instantiate mappable directly, despite some methods being abstract). It should be class mappable(metaclass=abc.ABCMeta) on Python 3.
But I realize that there are other __metaclass__ = abc.ABCMeta in the code base. Do we handle this somehow or has this been overlooked?

dlax added inline comments.Nov 7 2019, 3:26 AM
mercurial/templateutil.py
114

Just seen D7272 and others which explain this. Nevermind.

durin42 added a commit: rHG3e57809d3251: templateutil: fix a missing ABCMeta assignment.Nov 7 2019, 3:31 AM
Closed by commit rHG3e57809d3251: templateutil: fix a missing ABCMeta assignment (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/templateutil.py (2 lines)

Diff 17632

mercurial/templateutil.py

A returned value must be serializable by templaterfilters.json(). A returned value must be serializable by templaterfilters.json().
""" """
class mappable(object): class mappable(object):
"""Object which can be converted to a single template mapping""" """Object which can be converted to a single template mapping"""
__metaclass__ = abc.ABCMeta
dlaxUnsubmitted
Not Done

This is ignored on Python 3 (meaning it's possible to instantiate mappable directly, despite some methods being abstract). It should be class mappable(metaclass=abc.ABCMeta) on Python 3.
But I realize that there are other __metaclass__ = abc.ABCMeta in the code base. Do we handle this somehow or has this been overlooked?

dlax: This is ignored on Python 3 (meaning it's possible to instantiate `mappable` directly, despite…
dlaxUnsubmitted
Not Done

Just seen D7272 and others which explain this. Nevermind.

dlax: Just seen D7272 and others which explain this. Nevermind.
def itermaps(self, context): def itermaps(self, context):
yield self.tomap(context) yield self.tomap(context)
@abc.abstractmethod @abc.abstractmethod
def tomap(self, context): def tomap(self, context):
"""Create a single template mapping representing this""" """Create a single template mapping representing this"""