( )⚙ D7266 vfs: add NotImplementedError version of join

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7266

vfs: add NotImplementedError version of join
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:56 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG8b0fa4de0064: vfs: add NotImplementedError version of join
Summary

Again, this helps out pytype.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 6 2019, 5:56 PM
indygreg accepted this revision.Nov 7 2019, 3:06 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:06 AM
durin42 added a commit: rHG8b0fa4de0064: vfs: add NotImplementedError version of join.Nov 7 2019, 3:31 AM
Closed by commit rHG8b0fa4de0064: vfs: add NotImplementedError version of join (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.
martinvonz added a subscriber: martinvonz.Nov 7 2019, 6:22 AM

I guess you meant s/NotImplementedError/abstractvfs/ in the commit message of this patch (and maybe on the parent patch as well)

Revision Contents
Changeset List

PathPackages
Mmercurial/vfs.py (3 lines)

Diff 17636

mercurial/vfs.py

raise NotImplementedError('attempted instantiating ' + str(type(self))) raise NotImplementedError('attempted instantiating ' + str(type(self)))
def __call__(self, path, mode=b'rb', **kwargs): def __call__(self, path, mode=b'rb', **kwargs):
raise NotImplementedError raise NotImplementedError
def _auditpath(self, path, mode): def _auditpath(self, path, mode):
raise NotImplementedError raise NotImplementedError
def join(self, path, *insidef):
raise NotImplementedError
def tryread(self, path): def tryread(self, path):
'''gracefully return an empty string for missing files''' '''gracefully return an empty string for missing files'''
try: try:
return self.read(path) return self.read(path)
except IOError as inst: except IOError as inst:
if inst.errno != errno.ENOENT: if inst.errno != errno.ENOENT:
raise raise
return b"" return b""