This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	17655		Nov 6 2019, 5:58 PM	★	★
Diff 2	17670		Nov 6 2019, 6:23 PM	★	★
Diff 3	17699	rHGda9ecbb1036876f5b56df07070b7d7bfe6566d2b	Nov 6 2019, 3:35 PM	★	★

Commit	Parents	Author	Summary	Date
fa754e3efbd5	5ccfb06797c3	Augie Fackler		Nov 6 2019, 3:35 PM

Status	Author	Revision
Closed	durin42	D7288 archival: suppress some incorrect pytype failures
Closed	durin42	D7287 simplemerge: disable a pytype error where it's just confused
Closed	durin42	D7286 match: suppress error about subscripting an exception
Closed	durin42	D7285 vfs: more attribute suppressions
Closed	durin42	D7284 mdiff: mark diffopts as having dynamic attributes
Closed	durin42	D7283 mail: suppress a pytype error that's just experimentally wrong
Closed	durin42	D7282 vfs: suppress some pytype errors around us using a private attribute
Closed	durin42	D7281 wireprototypes: disable pytype where it's just confused
Closed	durin42	D7280 scmposix: another suppression on IOError subscripting
Closed	durin42	D7279 pvec: add an explicit type hint to help pytype
Closed	durin42	D7278 procutil: suppress pytype warnings around windows-only attributes
Closed	durin42	D7277 dagparser: suppress some pytype errors around pycompat.bytestring
Closed	durin42	D7276 posix: add a pytype suppression
Closed	durin42	D7275 encoding: add comment-based type hints for pytype
Closed	durin42	D7274 color: suppress pytype warning on a windows-only module
Closed	durin42	D7273 compression: tell pytype to not sweat a missing `zstd` module
Closed	durin42	D7272 pytype: don't warn us about ignored-on-py3 metaclasses
Closed	durin42	D7271 linelog: be more careful about types before looking for _target attribute
Closed	durin42	D7270 linelog: suppress annoying pytype warning about an ignored metaclass
Closed	durin42	D7269 hgignore: ignore generated pytype stubs
Closed	durin42	D7268 hghave: add a check for pytype, Google's Python type checker
Closed	durin42	D7267 encoding: define local identify functions with explicit type comments
Closed	durin42	D7266 vfs: add NotImplementedError version of join
Closed	durin42	D7265 vfs: add a NotImplementedError implementation of __call__
Closed	durin42	D7264 vfs: fix erroneous bytes constants
Closed	durin42	D7263 pvec: migrate to modern integer division
Closed	durin42	D7262 templateutil: fix a missing ABCMeta assignment
Closed	durin42	D7261 pvec: fix overlooked chr() call
Closed	durin42	D7260 vfs: another bytes-str confusion on thread name
Closed	durin42	D7259 statprof: correctly always pass a str as the thread name

Diff 17655

mercurial/vfs.py

	% mode			% mode
	)			)
	fp = checkambigatclosing(fp)			fp = checkambigatclosing(fp)

	if backgroundclose and isinstance(			if backgroundclose and isinstance(
	threading.currentThread(),			threading.currentThread(),
	threading._MainThread, # pytype: disable=module-attr			threading._MainThread, # pytype: disable=module-attr
	):			):
	if not self._backgroundfilecloser:			if (
				not self._backgroundfilecloser
				): # pytype: disable=attribute-error
	raise error.Abort(			raise error.Abort(
	_(			_(
	b'backgroundclose can only be used when a '			b'backgroundclose can only be used when a '
	b'backgroundclosing context manager is active'			b'backgroundclosing context manager is active'
	)			)
	)			)

	fp = delayclosedfile(fp, self._backgroundfilecloser)			fp = delayclosedfile(
				fp, self._backgroundfilecloser
				) # pytype: disable=attribute-error

	return fp			return fp

	def symlink(self, src, dst):			def symlink(self, src, dst):
	self.audit(dst)			self.audit(dst)
	linkname = self.join(dst)			linkname = self.join(dst)
	util.tryunlink(linkname)			util.tryunlink(linkname)

This is an archive of the discontinued Mercurial Phabricator instance.

vfs: more attribute suppressionsClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17655

mercurial/vfs.py

vfs: more attribute suppressions
ClosedPublic

Revision Contents
Changeset List