( )⚙ D7285 vfs: more attribute suppressions

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7285

vfs: more attribute suppressions
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:58 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGda9ecbb10368: vfs: more attribute suppressions

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 6 2019, 5:58 PM
durin42 updated this revision to Diff 17670.Nov 6 2019, 6:23 PM
indygreg accepted this revision.Nov 7 2019, 3:19 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:19 AM
durin42 added a commit: rHGda9ecbb10368: vfs: more attribute suppressions.Nov 7 2019, 3:34 AM
Closed by commit rHGda9ecbb10368: vfs: more attribute suppressions (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/vfs.py (9 lines)

Diff 17670

mercurial/vfs.py

% mode % mode
) )
fp = checkambigatclosing(fp) fp = checkambigatclosing(fp)
if backgroundclose and isinstance( if backgroundclose and isinstance(
threading.currentThread(), threading.currentThread(),
threading._MainThread, # pytype: disable=module-attr threading._MainThread, # pytype: disable=module-attr
): ):
if not self._backgroundfilecloser: if (
not self._backgroundfilecloser # pytype: disable=attribute-error
):
raise error.Abort( raise error.Abort(
_( _(
b'backgroundclose can only be used when a ' b'backgroundclose can only be used when a '
b'backgroundclosing context manager is active' b'backgroundclosing context manager is active'
) )
) )
fp = delayclosedfile(fp, self._backgroundfilecloser) fp = delayclosedfile(
fp,
self._backgroundfilecloser, # pytype: disable=attribute-error
)
return fp return fp
def symlink(self, src, dst): def symlink(self, src, dst):
self.audit(dst) self.audit(dst)
linkname = self.join(dst) linkname = self.join(dst)
util.tryunlink(linkname) util.tryunlink(linkname)