( )⚙ D8440 rust-chg: exclude futures-dependent modules from build and break things

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8440

rust-chg: exclude futures-dependent modules from build and break things
ClosedPublic

Authored by yuja on Apr 16 2020, 8:29 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG8685add122ff: rust-chg: exclude futures-dependent modules from build and break things
Summary

It's impractical to upgrade the codebase incrementally since futures 0.1
and 0.3 APIs are fundamentally different. So this patch temporarily excludes
futures-dependent modules from the build. These modules will be upgraded
and re-enabled one by one.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

yuja created this revision.Apr 16 2020, 8:29 AM
Alphare accepted this revision.Apr 17 2020, 7:53 AM
yuja added a commit: rHG8685add122ff: rust-chg: exclude futures-dependent modules from build and break things.Apr 23 2020, 2:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG8685add122ff: rust-chg: exclude futures-dependent modules from build and break things (authored by yuja). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/chg/Cargo.toml (3 lines)
Mrust/chg/src/lib.rs (14 lines)

Diff 21117

rust/chg/Cargo.toml

[package] [package]
name = "chg" name = "chg"
version = "0.1.0" version = "0.1.0"
authors = ["Yuya Nishihara <yuya@tcha.org>"] authors = ["Yuya Nishihara <yuya@tcha.org>"]
description = "Client for Mercurial command server with cHg extension" description = "Client for Mercurial command server with cHg extension"
license = "GPL-2.0+" license = "GPL-2.0+"
edition = "2018" edition = "2018"
# TODO: enable auto discovery
autobins = false
[dependencies] [dependencies]
bytes = "0.4" bytes = "0.4"
futures = "0.1" futures = "0.1"
libc = "0.2" libc = "0.2"
log = { version = "0.4", features = ["std"] } log = { version = "0.4", features = ["std"] }
tokio = "0.1" tokio = "0.1"
tokio-hglib = "0.2" tokio-hglib = "0.2"
tokio-process = "0.2.3" tokio-process = "0.2.3"
tokio-timer = "0.2" tokio-timer = "0.2"
[build-dependencies] [build-dependencies]
cc = "1.0" cc = "1.0"

rust/chg/src/lib.rs

// Copyright 2018 Yuya Nishihara <yuya@tcha.org> // Copyright 2018 Yuya Nishihara <yuya@tcha.org>
// //
// This software may be used and distributed according to the terms of the // This software may be used and distributed according to the terms of the
// GNU General Public License version 2 or any later version. // GNU General Public License version 2 or any later version.
mod attachio; //mod attachio;
mod clientext; //mod clientext;
pub mod locator; //pub mod locator;
pub mod message; pub mod message;
pub mod procutil; pub mod procutil;
mod runcommand; //mod runcommand;
mod uihandler; //mod uihandler;
pub use clientext::ChgClientExt; //pub use clientext::ChgClientExt;
pub use uihandler::{ChgUiHandler, SystemHandler}; //pub use uihandler::{ChgUiHandler, SystemHandler};