This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9574

upgrade: move `print_affected_revlogs()` to UpgradeOperation class
ClosedPublic

Authored by pulkit on Dec 14 2020, 4:55 AM.

Details

Reviewers
marmoute
mharbison72
Group Reviewers
hg-reviewers
Commits
rHG945b33a7edfd: upgrade: move `print_affected_revlogs()` to UpgradeOperation class
Summary

Part of refactor where we make things more arranged and integrated into single
UpgradeOperation class.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Dec 14 2020, 4:55 AM
pulkit added a comment.Dec 21 2020, 7:00 AM

Review ping for this series.

marmoute accepted this revision.Dec 22 2020, 3:31 AM
pulkit added a comment.Jan 5 2021, 2:34 AM

Review ping for this series.

Motive of the series: Right now the upgrade operation blindly upgrades everything even if does not need to. For example, features like persistent-nodemap, share-safe etc. does not need to touch filelogs. The optimizations will make certain upgrade operations instantaneous on large repositories. This series refactors upgrade code to implement partial upgrades depending on what should be upgraded.

mharbison72 accepted this revision.Jan 5 2021, 10:34 AM
This revision is now accepted and ready to land.Jan 5 2021, 10:34 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/upgrade.py (14 lines)
Mmercurial/upgrade_utils/actions.py (12 lines)

Diff 24198

mercurial/upgrade.py

"upgrade-repo.optimisation.performed", "upgrade-repo.optimisation.performed",
) )
ui.write(b'\n\n') ui.write(b'\n\n')
def printupgradeactions(): def printupgradeactions():
for a in actions: for a in actions:
ui.status(b'%s\n %s\n\n' % (a.name, a.upgrademessage)) ui.status(b'%s\n %s\n\n' % (a.name, a.upgrademessage))
def print_affected_revlogs():
if not revlogs:
ui.write((b'no revlogs to process\n'))
else:
ui.write((b'processed revlogs:\n'))
for r in sorted(revlogs):
ui.write((b' - %s\n' % r))
ui.write((b'\n'))
upgrade_op = upgrade_actions.UpgradeOperation( upgrade_op = upgrade_actions.UpgradeOperation(
ui,
newreqs, newreqs,
[a.name for a in actions], [a.name for a in actions],
revlogs, revlogs,
) )
if not run: if not run:
fromconfig = [] fromconfig = []
onlydefault = [] onlydefault = []
b'performing an upgrade with "--run" will make the following ' b'performing an upgrade with "--run" will make the following '
b'changes:\n\n' b'changes:\n\n'
) )
) )
printrequirements() printrequirements()
printoptimisations() printoptimisations()
printupgradeactions() printupgradeactions()
print_affected_revlogs() upgrade_op.print_affected_revlogs()
unusedoptimize = [i for i in alloptimizations if i not in actions] unusedoptimize = [i for i in alloptimizations if i not in actions]
if unusedoptimize: if unusedoptimize:
ui.status( ui.status(
_( _(
b'additional optimizations are available by specifying ' b'additional optimizations are available by specifying '
b'"--optimize <name>":\n\n' b'"--optimize <name>":\n\n'
) )
) )
for i in unusedoptimize: for i in unusedoptimize:
ui.status(_(b'%s\n %s\n\n') % (i.name, i.description)) ui.status(_(b'%s\n %s\n\n') % (i.name, i.description))
return return
# Else we're in the run=true case. # Else we're in the run=true case.
ui.write(_(b'upgrade will perform the following actions:\n\n')) ui.write(_(b'upgrade will perform the following actions:\n\n'))
printrequirements() printrequirements()
printoptimisations() printoptimisations()
printupgradeactions() printupgradeactions()
print_affected_revlogs() upgrade_op.print_affected_revlogs()
ui.status(_(b'beginning upgrade...\n')) ui.status(_(b'beginning upgrade...\n'))
with repo.wlock(), repo.lock(): with repo.wlock(), repo.lock():
ui.status(_(b'repository locked and read-only\n')) ui.status(_(b'repository locked and read-only\n'))
# Our strategy for upgrading the repository is to create a new, # Our strategy for upgrading the repository is to create a new,
# temporary repository, write data to it, then do a swap of the # temporary repository, write data to it, then do a swap of the
# data. There are less heavyweight ways to do this, but it is easier # data. There are less heavyweight ways to do this, but it is easier
# to create a new repo object than to instantiate all the components # to create a new repo object than to instantiate all the components

mercurial/upgrade_utils/actions.py

# e.g. adding generaldelta could schedule parent redeltas. # e.g. adding generaldelta could schedule parent redeltas.
return newactions return newactions
class UpgradeOperation(object): class UpgradeOperation(object):
"""represent the work to be done during an upgrade""" """represent the work to be done during an upgrade"""
def __init__(self, requirements, actions, revlogs_to_process): def __init__(self, ui, requirements, actions, revlogs_to_process):
self.ui = ui
self.requirements = requirements self.requirements = requirements
self.actions = actions self.actions = actions
self.revlogs_to_process = revlogs_to_process self.revlogs_to_process = revlogs_to_process
def print_affected_revlogs(self):
if not self.revlogs_to_process:
self.ui.write((b'no revlogs to process\n'))
else:
self.ui.write((b'processed revlogs:\n'))
for r in sorted(self.revlogs_to_process):
self.ui.write((b' - %s\n' % r))
self.ui.write((b'\n'))
### Code checking if a repository can got through the upgrade process at all. # ### Code checking if a repository can got through the upgrade process at all. #
def requiredsourcerequirements(repo): def requiredsourcerequirements(repo):
"""Obtain requirements required to be present to upgrade a repo. """Obtain requirements required to be present to upgrade a repo.
An upgrade will not be allowed if the repository doesn't have the An upgrade will not be allowed if the repository doesn't have the