This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	24208		Dec 14 2020, 5:52 AM	★	★
Diff 2	24299		Dec 16 2020, 5:14 AM	★	★
Diff 3	24751	rHGe2139e071b5c192b27e4f1086cf3c6e7fab297c8	Dec 14 2020, 5:45 AM	★	★

Status	Author	Revision
Closed	pulkit	D9775 upgrade: update only requirements if we can
Closed	pulkit	D9774 engine: add `if True` to prepare for next patch
Closed	pulkit	D9773 test: unquiet few tests to demonstrate changes in upcoming patches
Closed	pulkit	D9772 upgrade: mark sharesafe improvement as only touching requirements
Closed	pulkit	D9771 actions: calculate what all parts does the operation touches
Closed	pulkit	D9770 upgrade: don't create store backup if `--no-backup` is passed
Changes Planned	pulkit	D9677 upgrade: use copy+delete instead of rename while creating backup
Closed	pulkit	D9695 upgrade: don't perform anything if nothing to do
Closed	pulkit	D9676 upgrade: migrated -> upgraded in ui messages
Closed	pulkit	D9675 upgrade: remove unnecessary `is None` check
Closed	pulkit	D9674 engine: refactor code to replace stores in separate function
Closed	pulkit	D9694 upgrade: demonstrate that a no-op upgrade still performs everything
Closed	pulkit	D9693 downgrade: if a compression is removed, consider that too
Closed	pulkit	D9673 engine: prevent a function call for each store file
Closed	pulkit	D9672 engine: make hook point for extension a public function
Closed	pulkit	D9669 engine: prevent multiple checking of re-delta-multibase
Closed	pulkit	D9668 engine: pass upgrade operation inside `_perform_clone()`
Closed	pulkit	D9667 engine: pass upgrade operation inside _clonerevlogs()
Closed	pulkit	D9666 actions: store deltareuse mode of whole operation in UpgradeOperation
Closed	pulkit	D9665 engine: refactor how total dstsize is calculated
Closed	pulkit	D9619 upgrade: introduce post upgrade and downgrade message for improvements
Closed	pulkit	D9618 actions: introduce function to calculate downgrades
Closed	pulkit	D9617 debugupgraderepo: minor documentation fix
Closed	pulkit	D9616 upgrade: rename actions to upgrade_actions
Closed	pulkit	D9615 upgrade: move optimization addition to determineactions()
Closed	pulkit	D9614 upgrade: drop support for old style optimization names
Closed	pulkit	D9583 upgrade: add a missing space in status message
Closed	pulkit	D9664 actions: rename DEFICIENCY constant to FORMAT_VARIANT
Closed	pulkit	D9582 upgrade: rename finddeficiences() to find_format_upgrades()
Closed	pulkit	D9580 engine: unwrap a hard to understand for loop
Closed	pulkit	D9579 engine: refactor actual cloning code into separate function
Closed	pulkit	D9578 upgrade: move printing of unused optimizations to UpgradeOperation class
Closed	pulkit	D9577 upgrade: move `printrequirements()` to UpgradeOperation class
Closed	pulkit	D9576 upgrade: move `printoptimisations() to UpgradeOperation class
Closed	pulkit	D9575 upgrade: move `printupgradeactions()` to UpgradeOperation class
Closed	pulkit	D9574 upgrade: move `print_affected_revlogs()` to UpgradeOperation class

Diff 24751

mercurial/upgrade.py

	dstrepo = hg.repository(repoui, path=tmppath, create=True)			dstrepo = hg.repository(repoui, path=tmppath, create=True)

	with dstrepo.wlock(), dstrepo.lock():			with dstrepo.wlock(), dstrepo.lock():
	backuppath = upgrade_engine.upgrade(			backuppath = upgrade_engine.upgrade(
	ui, repo, dstrepo, upgrade_op			ui, repo, dstrepo, upgrade_op
	)			)
	if not (backup or backuppath is None):			if not (backup or backuppath is None):
	ui.status(			ui.status(
	_(b'removing old repository content%s\n') % backuppath			_(b'removing old repository content %s\n') % backuppath
	)			)
	repo.vfs.rmtree(backuppath, forcibly=True)			repo.vfs.rmtree(backuppath, forcibly=True)
	backuppath = None			backuppath = None

	finally:			finally:
	ui.status(_(b'removing temporary repository %s\n') % tmppath)			ui.status(_(b'removing temporary repository %s\n') % tmppath)
	repo.vfs.rmtree(tmppath, forcibly=True)			repo.vfs.rmtree(tmppath, forcibly=True)

tests/test-upgrade-repo.t

	copying phaseroots			copying phaseroots
	data fully migrated to temporary repository			data fully migrated to temporary repository
	marking source repository as being upgraded; clients will be unable to read from repository			marking source repository as being upgraded; clients will be unable to read from repository
	starting in-place swap of repository data			starting in-place swap of repository data
	replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	replacing store...			replacing store...
	store replacement complete; repository was inconsistent for * (glob)			store replacement complete; repository was inconsistent for * (glob)
	finalizing requirements file and making repository readable again			finalizing requirements file and making repository readable again
	removing old repository content$TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			removing old repository content $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)			removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)
	$ ls -1 .hg/ \| grep upgradebackup			$ ls -1 .hg/ \| grep upgradebackup
	[1]			[1]

	We can restrict optimization to some revlog:			We can restrict optimization to some revlog:

	$ hg debugupgrade --optimize re-delta-parent --run --manifest --no-backup --debug --traceback			$ hg debugupgrade --optimize re-delta-parent --run --manifest --no-backup --debug --traceback
	upgrade will perform the following actions:			upgrade will perform the following actions:
	copying phaseroots			copying phaseroots
	data fully migrated to temporary repository			data fully migrated to temporary repository
	marking source repository as being upgraded; clients will be unable to read from repository			marking source repository as being upgraded; clients will be unable to read from repository
	starting in-place swap of repository data			starting in-place swap of repository data
	replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	replacing store...			replacing store...
	store replacement complete; repository was inconsistent for *s (glob)			store replacement complete; repository was inconsistent for *s (glob)
	finalizing requirements file and making repository readable again			finalizing requirements file and making repository readable again
	removing old repository content$TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			removing old repository content $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)			removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)

	Check that the repo still works fine			Check that the repo still works fine

	$ hg log -G --stat			$ hg log -G --stat
	@ changeset: 2:76d4395f5413 (no-py3 !)			@ changeset: 2:76d4395f5413 (no-py3 !)
	@ changeset: 2:fca376863211 (py3 !)			@ changeset: 2:fca376863211 (py3 !)
	\| tag: tip			\| tag: tip
	copying phaseroots			copying phaseroots
	data fully migrated to temporary repository			data fully migrated to temporary repository
	marking source repository as being upgraded; clients will be unable to read from repository			marking source repository as being upgraded; clients will be unable to read from repository
	starting in-place swap of repository data			starting in-place swap of repository data
	replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	replacing store...			replacing store...
	store replacement complete; repository was inconsistent for *s (glob)			store replacement complete; repository was inconsistent for *s (glob)
	finalizing requirements file and making repository readable again			finalizing requirements file and making repository readable again
	removing old repository content$TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			removing old repository content $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)			removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)
	$ hg verify			$ hg verify
	checking changesets			checking changesets
	checking manifests			checking manifests
	crosschecking files in changesets and manifests			crosschecking files in changesets and manifests
	checking files			checking files
	checked 3 changesets with 3 changes to 3 files			checked 3 changesets with 3 changes to 3 files

	copying phaseroots			copying phaseroots
	data fully migrated to temporary repository			data fully migrated to temporary repository
	marking source repository as being upgraded; clients will be unable to read from repository			marking source repository as being upgraded; clients will be unable to read from repository
	starting in-place swap of repository data			starting in-place swap of repository data
	replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	replacing store...			replacing store...
	store replacement complete; repository was inconsistent for *s (glob)			store replacement complete; repository was inconsistent for *s (glob)
	finalizing requirements file and making repository readable again			finalizing requirements file and making repository readable again
	removing old repository content$TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			removing old repository content $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)			removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)
	$ hg verify			$ hg verify
	checking changesets			checking changesets
	checking manifests			checking manifests
	crosschecking files in changesets and manifests			crosschecking files in changesets and manifests
	checking files			checking files
	checked 3 changesets with 3 changes to 3 files			checked 3 changesets with 3 changes to 3 files

	copying phaseroots			copying phaseroots
	data fully migrated to temporary repository			data fully migrated to temporary repository
	marking source repository as being upgraded; clients will be unable to read from repository			marking source repository as being upgraded; clients will be unable to read from repository
	starting in-place swap of repository data			starting in-place swap of repository data
	replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	replacing store...			replacing store...
	store replacement complete; repository was inconsistent for *s (glob)			store replacement complete; repository was inconsistent for *s (glob)
	finalizing requirements file and making repository readable again			finalizing requirements file and making repository readable again
	removing old repository content$TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			removing old repository content $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)			removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)
	$ hg verify			$ hg verify
	checking changesets			checking changesets
	checking manifests			checking manifests
	crosschecking files in changesets and manifests			crosschecking files in changesets and manifests
	checking files			checking files
	checked 3 changesets with 3 changes to 3 files			checked 3 changesets with 3 changes to 3 files

	copying phaseroots			copying phaseroots
	data fully migrated to temporary repository			data fully migrated to temporary repository
	marking source repository as being upgraded; clients will be unable to read from repository			marking source repository as being upgraded; clients will be unable to read from repository
	starting in-place swap of repository data			starting in-place swap of repository data
	replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	replacing store...			replacing store...
	store replacement complete; repository was inconsistent for *s (glob)			store replacement complete; repository was inconsistent for *s (glob)
	finalizing requirements file and making repository readable again			finalizing requirements file and making repository readable again
	removing old repository content$TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			removing old repository content $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)			removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)
	$ hg verify			$ hg verify
	checking changesets			checking changesets
	checking manifests			checking manifests
	crosschecking files in changesets and manifests			crosschecking files in changesets and manifests
	checking files			checking files
	checked 3 changesets with 3 changes to 3 files			checked 3 changesets with 3 changes to 3 files

	copying phaseroots			copying phaseroots
	data fully migrated to temporary repository			data fully migrated to temporary repository
	marking source repository as being upgraded; clients will be unable to read from repository			marking source repository as being upgraded; clients will be unable to read from repository
	starting in-place swap of repository data			starting in-place swap of repository data
	replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			replaced files will be backed up at $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	replacing store...			replacing store...
	store replacement complete; repository was inconsistent for *s (glob)			store replacement complete; repository was inconsistent for *s (glob)
	finalizing requirements file and making repository readable again			finalizing requirements file and making repository readable again
	removing old repository content$TESTTMP/upgradegd/.hg/upgradebackup.* (glob)			removing old repository content $TESTTMP/upgradegd/.hg/upgradebackup.* (glob)
	removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)			removing temporary repository $TESTTMP/upgradegd/.hg/upgrade.* (glob)
	$ hg verify			$ hg verify
	checking changesets			checking changesets
	checking manifests			checking manifests
	crosschecking files in changesets and manifests			crosschecking files in changesets and manifests
	checking files			checking files
	checked 3 changesets with 3 changes to 3 files			checked 3 changesets with 3 changes to 3 files

This is an archive of the discontinued Mercurial Phabricator instance.

upgrade: add a missing space in status messageClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24751

mercurial/upgrade.py

tests/test-upgrade-repo.t

upgrade: add a missing space in status message
ClosedPublic

Revision Contents
Changeset List