This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9665

engine: refactor how total dstsize is calculated
ClosedPublic

Authored by pulkit on Dec 30 2020, 6:53 AM.

Details

Reviewers
marmoute
mharbison72
Group Reviewers
hg-reviewers
Commits
rHG5dfa837d933e: engine: refactor how total dstsize is calculated
Summary

Instead of increasing it with each revlog, we just get the sum of total
destination changelog, manifest and filelogs sizes.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Dec 30 2020, 6:53 AM
marmoute accepted this revision.Jan 7 2021, 8:07 PM
mharbison72 accepted this revision.Jan 12 2021, 6:45 PM
This revision is now accepted and ready to land.Jan 12 2021, 6:45 PM
pulkit added a commit: rHG5dfa837d933e: engine: refactor how total dstsize is calculated.Jan 12 2021, 6:53 PM
Closed by commit rHG5dfa837d933e: engine: refactor how total dstsize is calculated (authored by pulkit). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/upgrade_utils/engine.py (13 lines)

Diff 24549

mercurial/upgrade_utils/engine.py

unencoded, unencoded,
deltareuse, deltareuse,
forcedeltabothparents, forcedeltabothparents,
revlogs, revlogs,
sidedatacompanion, sidedatacompanion,
oncopiedrevision, oncopiedrevision,
) )
info = newrl.storageinfo(storedsize=True) info = newrl.storageinfo(storedsize=True)
datasize = info[b'storedsize'] or 0 fdstsize += info[b'storedsize'] or 0
dstsize += datasize
fdstsize += datasize
ui.status( ui.status(
_( _(
b'finished migrating %d filelog revisions across %d ' b'finished migrating %d filelog revisions across %d '
b'filelogs; change in size: %s\n' b'filelogs; change in size: %s\n'
) )
% (frevcount, fcount, util.bytecount(fdstsize - fsrcsize)) % (frevcount, fcount, util.bytecount(fdstsize - fsrcsize))
) )
unencoded, unencoded,
deltareuse, deltareuse,
forcedeltabothparents, forcedeltabothparents,
revlogs, revlogs,
sidedatacompanion, sidedatacompanion,
oncopiedrevision, oncopiedrevision,
) )
info = newrl.storageinfo(storedsize=True) info = newrl.storageinfo(storedsize=True)
datasize = info[b'storedsize'] or 0 mdstsize += info[b'storedsize'] or 0
dstsize += datasize
mdstsize += datasize
ui.status( ui.status(
_( _(
b'finished migrating %d manifest revisions across %d ' b'finished migrating %d manifest revisions across %d '
b'manifests; change in size: %s\n' b'manifests; change in size: %s\n'
) )
% (mrevcount, mcount, util.bytecount(mdstsize - msrcsize)) % (mrevcount, mcount, util.bytecount(mdstsize - msrcsize))
) )
unencoded, unencoded,
deltareuse, deltareuse,
forcedeltabothparents, forcedeltabothparents,
revlogs, revlogs,
sidedatacompanion, sidedatacompanion,
oncopiedrevision, oncopiedrevision,
) )
info = newrl.storageinfo(storedsize=True) info = newrl.storageinfo(storedsize=True)
datasize = info[b'storedsize'] or 0 cdstsize += info[b'storedsize'] or 0
dstsize += datasize
cdstsize += datasize
progress.complete() progress.complete()
ui.status( ui.status(
_( _(
b'finished migrating %d changelog revisions; change in size: ' b'finished migrating %d changelog revisions; change in size: '
b'%s\n' b'%s\n'
) )
% (crevcount, util.bytecount(cdstsize - csrcsize)) % (crevcount, util.bytecount(cdstsize - csrcsize))
) )
dstsize = fdstsize + mdstsize + cdstsize
ui.status( ui.status(
_( _(
b'finished migrating %d total revisions; total change in store ' b'finished migrating %d total revisions; total change in store '
b'size: %s\n' b'size: %s\n'
) )
% (revcount, util.bytecount(dstsize - srcsize)) % (revcount, util.bytecount(dstsize - srcsize))
) )