Page MenuHomePhabricator

sharesafe: add functionality to automatically downgrade shares
ClosedPublic

Authored by pulkit on Wed, Jan 6, 8:21 AM.

Details

Summary

Reasoning is same as previous patch which adds automatic upgrade support.

Downgrade is required as if automatic upgrade is enabled, all shares upgrade and
then source repository downgrades, shares won't work. We need to downgrade them.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Wed, Jan 6, 8:21 AM
baymax updated this revision to Diff 24621.Wed, Jan 6, 10:14 AM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

marmoute requested changes to this revision.Wed, Jan 6, 5:14 PM
marmoute added a subscriber: marmoute.

same feedback as D9679 โ˜บ

This revision now requires changes to proceed.Wed, Jan 6, 5:14 PM
pulkit updated this revision to Diff 24625.Thu, Jan 7, 6:47 AM
baymax updated this revision to Diff 24631.Fri, Jan 8, 7:56 AM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

pulkit updated this revision to Diff 24644.Fri, Jan 8, 11:24 AM

(I assume the same feedback apply there)

pulkit added a comment.Sat, Jan 9, 6:27 AM

(I assume the same feedback apply there)

Yes, incorporated those already.

baymax updated this revision to Diff 24694.Sat, Jan 9, 8:03 AM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

Alphare accepted this revision.Tue, Jan 12, 11:28 AM
pulkit updated this revision to Diff 24776.Wed, Jan 13, 6:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.