Page MenuHomePhabricator
Differential D9680

sharesafe: add functionality to automatically downgrade shares
ClosedPublic
Actions

Authored by pulkit on Wed, Jan 6, 8:21 AM.

Details

Reviewers
marmoute
Alphare
Group Reviewers
hg-reviewers
Commits
rHGeec47efe219d: sharesafe: add functionality to automatically downgrade shares
Summary

Reasoning is same as previous patch which adds automatic upgrade support.

Downgrade is required as if automatic upgrade is enabled, all shares upgrade and
then source repository downgrades, shares won't work. We need to downgrade them.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Wed, Jan 6, 8:21 AM
baymax updated this revision to Diff 24621.Wed, Jan 6, 10:14 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute requested changes to this revision.Wed, Jan 6, 5:14 PM
marmoute added a subscriber: marmoute.

same feedback as D9679 ☺

This revision now requires changes to proceed.Wed, Jan 6, 5:14 PM
pulkit updated this revision to Diff 24625.Thu, Jan 7, 6:47 AM
baymax updated this revision to Diff 24631.Fri, Jan 8, 7:56 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit updated this revision to Diff 24644.Fri, Jan 8, 11:24 AM
marmoute added a comment.Fri, Jan 8, 6:11 PM

(I assume the same feedback apply there)

pulkit added a comment.Sat, Jan 9, 6:27 AM
In D9680#146569, @marmoute wrote:

(I assume the same feedback apply there)

Yes, incorporated those already.

baymax updated this revision to Diff 24694.Sat, Jan 9, 8:03 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Tue, Jan 12, 11:28 AM
pulkit updated this revision to Diff 24776.Wed, Jan 13, 6:30 AM
pulkit added a commit: rHGeec47efe219d: sharesafe: add functionality to automatically downgrade shares.Wed, Jan 13, 2:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGeec47efe219d: sharesafe: add functionality to automatically downgrade shares (authored by pulkit). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24795

View Options

mercurial/configitems.py

Loading...
View Options

mercurial/localrepo.py

Loading...
View Options

mercurial/upgrade.py

Loading...
View Options

tests/test-share-safe.t

Loading...